Skip to content

Pre-release translations #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2019
Merged

Pre-release translations #498

merged 3 commits into from
May 16, 2019

Conversation

sseerrggii
Copy link
Contributor

No description provided.

@sseerrggii sseerrggii changed the title Pre-release translations WIP Pre-release translations May 16, 2019
@sseerrggii sseerrggii changed the title WIP Pre-release translations WIP: Pre-release translations May 16, 2019
@sseerrggii
Copy link
Contributor Author

Seems like localeapp use 'other' as a function for pluralize and for this reason we can't add it to localeapp

FireShot Capture 225 - coopdevs_timeoverflow - Locale - app localeapp com

I'll commit a solution (change other for others) in this PR, is it ok?

@sseerrggii sseerrggii requested a review from markets May 16, 2019 09:21
@sseerrggii sseerrggii changed the title WIP: Pre-release translations Pre-release translations May 16, 2019
@sseerrggii
Copy link
Contributor Author

Tested ✔️

@enricostano enricostano merged commit b1e7145 into develop May 16, 2019
@enricostano enricostano deleted the translations/20190516 branch May 16, 2019 10:23
@sseerrggii sseerrggii mentioned this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants