Skip to content

Feature/group offers #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2019
Merged

Feature/group offers #481

merged 3 commits into from
Mar 22, 2019

Conversation

Morantron
Copy link
Collaborator

description under construction

@Morantron
Copy link
Collaborator Author

#470

@Morantron
Copy link
Collaborator Author

some screenshots 📸

tag-list

tag-detail

image

@sseerrggii
Copy link
Contributor

sseerrggii commented Mar 19, 2019

Nice!! In form copy better as a question: "Is it a group offer?"

Other problem is that we will use this for offers and for inquiries (demands) so... copies will be:

"Group Offer"
"Group Inquirie"
"Is it a group offer?"
"Is it a group inquire?"

I will translate this to other languages after merge

@Morantron
Copy link
Collaborator Author

perfeito

@enricostano
Copy link
Contributor

@Morantron cool! 💪

Would you mind to update view tests? Or add any test that you see necessary? Thanks!

@Morantron
Copy link
Collaborator Author

image

@enricostano ?

@sseerrggii
Copy link
Contributor

I don't know why in staging I have an 500 Error on Post creation:

FireShot Capture 198 - Banc del Temps de Gràcia - staging timeoverflow org

Looking at logs I get this lines:

I, [2019-03-21T18:23:36.214866 #369]  INFO -- :   Rendered application/menus/_language_switcher.html.erb (2.3ms)
I, [2019-03-21T18:23:36.215329 #369]  INFO -- :   Rendered application/_footer.html.erb (7.6ms)
I, [2019-03-21T18:23:36.215557 #369]  INFO -- :   Rendered layouts/application.html.erb (71.9ms)
I, [2019-03-21T18:23:36.216635 #369]  INFO -- : Completed 500 Internal Server Error in 84ms (Views: 64.5ms | ActiveRecord: 10.5ms)

After few secons start CreatePushNotificationsJob things:

I, [2019-03-21T18:24:03.274684 #376]  INFO -- : [ActiveJob] [CreatePushNotificationsJob] [260fd6fb-7f88-4568-b41c-a654e6091da6] Performing CreatePushNotificationsJob from Sidekiq(default) with arguments: {:event_id=>10334}
D, [2019-03-21T18:24:03.277478 #376] DEBUG -- : [ActiveJob] [CreatePushNotificationsJob] [260fd6fb-7f88-4568-b41c-a654e6091da6]   Event Load (0.5ms)  SELECT  "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1  [["id", 10334]]

@sseerrggii
Copy link
Contributor

Tested
giphy

@sseerrggii sseerrggii merged commit 6d9bbde into develop Mar 22, 2019
@enricostano enricostano deleted the feature/group-posts branch March 23, 2019 10:11
@enricostano enricostano added this to the 1.13.0 milestone Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants