Skip to content

Report code coverage (via Code Climate) in CI #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2019
Merged

Conversation

markets
Copy link
Collaborator

@markets markets commented Mar 14, 2019

Closes #281
Closes #476
Closes #483

ℹ️ Docs: https://docs.codeclimate.com/docs/travis-ci-test-coverage#section-travis-ci-single-test-suite-non-parallel-builds

Pending:

  • Add ENV var CC_TEST_REPORTER_ID
  • Add coverage report badge in README

@markets markets marked this pull request as ready for review March 14, 2019 21:33
@markets markets added the wip label Mar 14, 2019
@enricostano
Copy link
Contributor

enricostano commented Mar 14, 2019

@sseerrggii @enricostano @sauloperez guys could you please give me access to Code Climate account or send me this var and the badge code?

Sadly I don't know which account has been used to set this up. It's something from 6 years ago... @sseerrggii knows maybe?

If we don't know... maybe we can create a new account for Coopdevs and point to the new one.
I'm not even sure what do we use Codeclimate for a part from the badge, cannot find any integration settings related to it in GitHub.

EDIT: For performance, APM, etc we use Skylight, @sauloperez do you know if they also have something for coverage automation?

@markets
Copy link
Collaborator Author

markets commented Mar 14, 2019

maybe we can create a new account for Coopdevs and point to the new one

👍 Code Climate is very useful for code quality and coverage reports and free for open source! We can eventually integrate it with GH pull requests. Seems Skylight does not provide those kind of features: https://www.skylight.io/features

@markets
Copy link
Collaborator Author

markets commented Mar 22, 2019

@sseerrggii could you please open a new account in Code Climate? Then, I'll need access to this new account or I'll need someone to send me those couple of "codes"

@markets markets force-pushed the ci_coverage branch 4 times, most recently from d95598a to d3f5b57 Compare March 22, 2019 17:47
@markets
Copy link
Collaborator Author

markets commented Mar 22, 2019

@enricostano @sauloperez ready :shipit:

Thank you a lot @sseerrggii for providing me all the stuff! 👇

Captura de pantalla 2019-03-22 a las 18 52 58

@markets markets mentioned this pull request Mar 22, 2019
@markets markets removed the wip label Mar 23, 2019
Copy link
Contributor

@enricostano enricostano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@enricostano enricostano added this to the 1.13.0 milestone Mar 23, 2019
@enricostano enricostano requested a review from sauloperez March 23, 2019 10:15
@markets markets removed this from the 1.13.0 milestone Apr 8, 2019
@markets markets mentioned this pull request Apr 8, 2019
@enricostano
Copy link
Contributor

@markets do you mind resolving the conflicts in this PR? Thanks!!! ❤️

@markets
Copy link
Collaborator Author

markets commented Apr 10, 2019

@enricostano done!

@enricostano
Copy link
Contributor

@markets broken specs 😅 😬

@markets
Copy link
Collaborator Author

markets commented Apr 10, 2019

@enricostano rebased again, now are passing, but anyway that previous broken build isn't related to this branch (I'm only tweaking the .travis.yml here), seems an intermittent failure IMHO

@enricostano enricostano merged commit b1746f3 into develop Apr 10, 2019
@enricostano enricostano deleted the ci_coverage branch April 10, 2019 15:42
@sauloperez
Copy link
Collaborator

I want those diff and total coverage reports in OFN 😱 ❤️

@sseerrggii sseerrggii mentioned this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants