Small controllers refactor #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markets
force-pushed
the
refactor_switch_lang
branch
2 times, most recently
from
bbe2579 to
791e5e2
Compare
markets
force-pushed
the
refactor_switch_lang
branch
from
791e5e2 to
2dda06f
Compare
enricostano
approved these changes
Feb 21, 2019
|
Tested 💚 language switcher work as usual |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAT?
Couple of minor cleanups:
removed unused store_location: Restore visit previous URL stored in session #249 has been closed, so there is no point of maintaining a
session[:previous_url]right nowmoved
switch_langaction toApplicationController+ added spec: => ✂️GlobalControllerthat only handles this action, so I think it's fine (and simpler) to move it to main/app controllerTESTING