Skip to content

[Security] Bump nokogiri from 1.8.4 to 1.8.5 #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2019
Merged

[Security] Bump nokogiri from 1.8.4 to 1.8.5 #438

merged 1 commit into from
Feb 15, 2019

Conversation

greysteil
Copy link

Bumps nokogiri from 1.8.4 to 1.8.5. This update includes security fixes.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

Nokogiri gem, via libxml2, is affected by multiple vulnerabilities
Nokogiri 1.8.5 has been released.

This is a security and bugfix release. It addresses two CVEs in upstream
libxml2 rated as "medium" by Red Hat, for which details are below.

If you're using your distro's system libraries, rather than Nokogiri's
vendored libraries, there's no security need to upgrade at this time,
though you may want to check with your distro whether they've patched this
(Canonical has patched Ubuntu packages). Note that these patches are not
yet (as of 2018-10-04) in an upstream release of libxml2.

Full details about the security update are available in Github Issue #1785.
[#1785]: https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/1785


[MRI] Pulled in upstream patches from libxml2 that address CVE-2018-14404
and CVE-2018-14567. Full details are available in #1785. Note that these
patches are not yet (as of 2018-10-04) in an upstream release of libxml2.

... (truncated)

Patched versions: >= 1.8.5
Unaffected versions: none

Changelog

Sourced from nokogiri's changelog.

1.8.5 / 2018-10-04

Security Notes

[MRI] Pulled in upstream patches from libxml2 that address CVE-2018-14404 and CVE-2018-14567. Full details are available in #1785. Note that these patches are not yet (as of 2018-10-04) in an upstream release of libxml2.

Bug fixes

  • [MRI] Fix regression in installation when building against system libraries, where some systems would not be able to find libxml2 or libxslt when present. (Regression introduced in v1.8.3.) [#1722]
  • [JRuby] Fix node reparenting when the destination doc is empty. [#1773]
Commits

Dependabot compatibility score

@enricostano - I kept Dependabot running on my fork and it generated this last night after the Nokogiri security advisory was announced. Would still love you to run it on this repo directly.

Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.8.4 to 1.8.5. **This update includes security fixes.**
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.8.4...v1.8.5)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@enricostano
Copy link
Contributor

Thanks @greysteil , I just added this PR to our testing queue 💪

@sseerrggii
Copy link
Contributor

I don't know how tot test that, becouse come from unknown repository origin 🤔

I tried to change the same line in Gemfile.lock and execute bundle install and everything went fine.

Can I merge it and we will test full application before the new release?

@greysteil
Copy link
Author

Sorry, this is a little old now and I deleted my fork. You should definitely be fine to merge, though!

@sseerrggii sseerrggii merged commit 8fcfad2 into coopdevs:develop Feb 15, 2019
@enricostano enricostano mentioned this pull request Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants