Skip to content

Use RSpec scope and avoid global namespace #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2018
Merged

Use RSpec scope and avoid global namespace #413

merged 1 commit into from
Aug 31, 2018

Conversation

markets
Copy link
Collaborator

@markets markets commented Aug 30, 2018

Closes #362

@markets markets mentioned this pull request Aug 30, 2018
Closed
@markets markets force-pushed the rspec_disable_global_dsl branch from af639ba to 22e09ed Compare August 30, 2018 18:53
enricostano
enricostano approved these changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@enricostano enricostano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@enricostano enricostano merged commit f7e4537 into develop Aug 31, 2018
@enricostano enricostano deleted the rspec_disable_global_dsl branch August 31, 2018 18:27
@enricostano enricostano mentioned this pull request Aug 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricostano enricostano enricostano approved these changes

@sauloperez sauloperez sauloperez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markets @enricostano @sauloperez