New /members page #406
New /members page #406
Conversation
mllocs
force-pushed
the
feature/members-page-refactor-with-cards
branch
from
e27ff7f to
d494993
Compare
|
Very good job @mllocs , I love it 😍! Testing in local I only noticed that a disabled member appears in the list of members. We don't want to show disabled members in this view. |
|
Also in second test round i found:
I'm thinking about the order in the new view of members. Can be better to see first the members ordered by activity, most active first. Can generate healthy competition 😈 |
config/locales/es.yml
Outdated
| @@ -546,6 +546,9 @@ es: | |||
| cancel_warning: Va a eliminar del banco al usuario %{user} | |||
| deactivate: Desactivar | |||
| manage_warning: Va a cambiar los privilegios del usuario %{user} | |||
| member_card: | |||
| no_activity: Sin actividad | |||
| active_ago: Activo hace %{time} | |||
There was a problem hiding this comment.
Also change en.yml please
There was a problem hiding this comment.
Yes en.yml, other languages are translated through locale app https://github.com/coopdevs/timeoverflow/wiki/Translations-Localeapp-i18n
|
Deployed to https://staging.timeoverflow.org |
|
Done, I fixed everything you mentioned @sseerrggii. |
|
@sseerrggii if you don't mind I'll keep the default order as it is (by member_uid) and tackle that in another PR ok? |
|
Tested!! 👍 👍 In the new view when there is no mail (@ example.com is not displayed) or there is no phone, it would be better to hide the icon
|
I agree, but maybe we can leave it for another PR. As @mllocs whishes. |
This page still needs to improve a lot, specially to fit small screens. Considers this as the first step 😄