Skip to content

Remove jquery-ui #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Remove jquery-ui #402

merged 1 commit into from
Aug 16, 2018

Conversation

markets
Copy link
Collaborator

@markets markets commented Aug 15, 2018

🔥 jquery-ui we only use the datepicker widget, and only in one place (statistics_global_activity view), so maybe it's fine to replace it with HTML 5 date input and reduce assets bundle size (jquery-ui it's big and old 😄).

NEW LOOK

captura de pantalla 2018-08-15 a la s 19 53 01

…global_activity view) so maybe it's fine to delete it and reduce assets bundle size :)
@enricostano
Copy link
Contributor

Deployed to https://staging.timeoverflow.org

@sseerrggii
Copy link
Contributor

Nice!!
In my opinion it's more practical than the previous date picker
👏 👏 👏

@enricostano enricostano merged commit 4320971 into develop Aug 16, 2018
@enricostano enricostano deleted the remove_jquery_ui branch August 16, 2018 09:39
@sseerrggii
Copy link
Contributor

@markets Can change translation of datapicker with locale ?

@enricostano enricostano mentioned this pull request Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants