Improved user menu on mobile #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markets
requested changes
Jun 12, 2018
| <% if current_user %> | ||
| <%= render 'application/menus/user_admin_menu' %> | ||
| <%= render 'application/menus/user_admin_menu' %> |
| <%= image_tag avatar_url(current_user) %> | ||
| <%= current_user.email %> | ||
| </li> | ||
| <%= render 'application/menus/user_admin_menu_items' %> |
There was a problem hiding this comment.
👀 indentation of this block
markets
approved these changes
Jun 12, 2018
markets
reviewed
Jun 12, 2018
| <% end %> | ||
| </li> | ||
|
|
||
|
|
enricostano
approved these changes
Jun 13, 2018
|
@mllocs |
enricostano
changed the base branch from
feature/move-language-selector-to-footer
to
develop
|
Deployed to https://staging.timeoverflow.org @mllocs please give a look and |
sauloperez
approved these changes
Jun 13, 2018
|
Deployed again to https://staging.timeoverflow.org/ |
|
@mllocs say it's OK 🍏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://g.recordit.co/aMnJR1VuBq.gif
Yet another lifting in our top navigation bar. Now I'm removing the unnecessary dropdown inception.