Move language selector to footer #378
Conversation
| <% I18n.available_locales.each do |locale| %> | ||
| <% if I18n.locale != locale %> | ||
| <li> | ||
| <%= link_to t("locales.#{locale}"), switch_lang_path(locale: locale) %> |
There was a problem hiding this comment.
Maybe we should use t("locales.#{locale}", locale: locale) here?
There was a problem hiding this comment.
why? that wouldn't be the same result. BTW, I just cut and pasted from one place to a separated file :)
There was a problem hiding this comment.
ah yes @mllocs! this is a proposal change, I think it's more natural for the users to see the language in their language.
There was a problem hiding this comment.
I agree too. Should it go in a different PR though?
There was a problem hiding this comment.
Not sure guys, in this case, if a different PR is necessary, with such a small change... ¯\_(ツ)_/¯. I'm totally +1 for small PRs, but now that we're touching the languages selector, maybe it's not a bad idea to add this change (no collateral effects) in this branch as well.
| <% I18n.available_locales.each do |locale| %> | ||
| <% if I18n.locale != locale %> | ||
| <li> | ||
| <%= link_to t("locales.#{locale}"), switch_lang_path(locale: locale) %> |
There was a problem hiding this comment.
I agree too. Should it go in a different PR though?
mllocs
force-pushed
the
feature/move-language-selector-to-footer
branch
from
4b8db79 to
cabe80f
Compare
| <% I18n.available_locales.each do |locale| %> | ||
| <% if I18n.locale != locale %> | ||
| <li> | ||
| <%= link_to t("locales.#{locale}", locale: locale), switch_lang_path(locale: locale) %> |
There was a problem hiding this comment.
@markets 😉
I didn't understand you the first time, I changed it 💪
mllocs
force-pushed
the
feature/move-language-selector-to-footer
branch
from
cabe80f to
c7c5af5
Compare
mllocs
changed the title
|
Deployed to https://staging.timeoverflow.org/ cc/ @mllocs @sseerrggii |
|
@enricostano @mllocs I just changed the base branch pointing to |
Oh! I didn't notice it wasn't pointing to |
|
I've found a little issue but I think we can merge and fix it later. In large screens and pages without lot of content, the footer looks like this:
Other than that |
http://g.recordit.co/Qz7JruPxF9.gif