Skip to content

Remove password_digest from users table (fixes #365) #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2018

Conversation

markets
Copy link
Collaborator

@markets markets commented May 25, 2018

Closes #365

@enricostano
Copy link
Contributor

OMG @markets I love you!

BTW... we're hiring... let's talk about it! 🎣 😂

Copy link
Collaborator

@sauloperez sauloperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gogogogo!

@enricostano
Copy link
Contributor

enricostano commented May 28, 2018

Deployed on https://staging.timeoverflow.org

Logging in with admin@timeoverflow.org I get the following error:

I, [2018-05-28T08:55:20.492048 #5274]  INFO -- : Started GET "/members" for 90.68.31.84 at 2018-05-28 08:55:20 +0000
I, [2018-05-28T08:55:20.496206 #5274]  INFO -- : Processing by UsersController#index as HTML
D, [2018-05-28T08:55:20.501866 #5274] DEBUG -- :   User Load (1.6ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = $1  ORDER BY users.id ASC LIMIT 1  [["id", 1]]
D, [2018-05-28T08:55:20.507490 #5274] DEBUG -- :   Document Load (1.0ms)  SELECT  "documents".* FROM "documents" WHERE "documents"."label" = $1 AND "documents"."documentable_id" IS NULL  ORDER BY "documents"."id" ASC LIMIT 1  [["label", "t&c"]]
D, [2018-05-28T08:55:20.517133 #5274] DEBUG -- :   Organization Load (1.6ms)  SELECT  "organizations".* FROM "organizations" INNER JOIN "members" ON "organizations"."id" = "members"."organization_id" WHERE "members"."user_id" = $1  ORDER BY "organizations"."id" ASC LIMIT 1  [["user_id", 1]]
I, [2018-05-28T08:55:20.532159 #5274]  INFO -- : Completed 401 Unauthorized in 36ms (ActiveRecord: 4.2ms)
D, [2018-05-28T08:55:20.534903 #5274] DEBUG -- : [Rollbar] Reporting exception: PG::UndefinedColumn: ERROR:  column users.password_digest does not exist

cc/ @markets

EDIT: LOL, if I run the migration first it could help 😅 😂

EDIT2: 🤔 the deploy runs the migrations already... so the migration is up 😬

EDIT3: restarting the unicorn.... #monday

@enricostano
Copy link
Contributor

Tested in staging 💚

@enricostano enricostano removed their assignment May 28, 2018
@enricostano enricostano merged commit b31466a into develop May 28, 2018
@enricostano enricostano deleted the remove_password_digest branch May 28, 2018 09:33
@enricostano enricostano mentioned this pull request Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants