Skip to content

Customizing bootstrap #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2018
Merged

Customizing bootstrap #350

merged 4 commits into from
May 22, 2018

Conversation

mllocs
Copy link
Collaborator

@mllocs mllocs commented May 8, 2018

  • Changed the primary color of the app.
  • Load bootstrap modules explicitly and only the ones that are needed.
  • Upgraded sass gem.
  • Removed "Tags" menu item for non admin users.

screen shot 2018-05-08 at 19 30 14

@mllocs mllocs requested review from enricostano and sauloperez May 8, 2018 18:03
@import "bootstrap/modals";
@import "bootstrap/tooltip";
// @import "bootstrap/popovers";
// @import "bootstrap/carousel";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simply remove the commented out ones, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left those comments because it could help future contributors understand that we are not loading all the modules. It's kind of an explicit way of saying which Bootstrap parts are not being used.

Copy link
Collaborator

@sauloperez sauloperez May 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO that could be a bit more clear if precede it with a comment block explaining just that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mllocs
Copy link
Collaborator Author

mllocs commented May 13, 2018

@mllocs mllocs force-pushed the feature/custom-bootstrap branch from a12e781 to 8181170 Compare May 15, 2018 21:47
@mllocs mllocs force-pushed the feature/custom-bootstrap branch from 8181170 to c10b3fb Compare May 15, 2018 21:49
<% if current_user.manages? current_organization %>
<%= render 'application/menus/offers_by_tag_link' %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this now only for admins?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @mllocs

cc/ @sseerrggii

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the last redesign conversations we had it was proposed to remove this section (to simplify the interface). Instead, I'm making it available only for admins.

@sauloperez sauloperez merged commit a75a76e into develop May 22, 2018
@sauloperez sauloperez deleted the feature/custom-bootstrap branch May 22, 2018 15:48
@enricostano enricostano mentioned this pull request Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants