Skip to content

add link to gravatar #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2018
Merged

add link to gravatar #337

merged 1 commit into from
Apr 4, 2018

Conversation

markets
Copy link
Collaborator

@markets markets commented Mar 18, 2018 •
edited
Loading

Closes #274

We want (before big change in avatar system) to put a link below avatar image to https://www.gravatar.com/

I18n

New key: users.show.change_your_image

captura de pantalla 2018-03-18 a la s 20 09 25

@markets
Copy link
Collaborator Author

markets commented Mar 18, 2018

@sauloperez @sseerrggii I'll need your help with translations :) could you please add this new key users.show.change_your_image in LocaleApp?

@sauloperez
Copy link
Collaborator

Sure!

@markets
Copy link
Collaborator Author

markets commented Mar 19, 2018 •
edited
Loading

hi guys 👋

I push-forced this branch with new translations, something weird happen with this @sseerrggii commit 37bee85 (Travis build https://travis-ci.org/coopdevs/timeoverflow/builds/355441976). Thanks!

@sauloperez
Copy link
Collaborator

Yep, I'll fix it tomorrow. Don't worry.

@sseerrggii
Copy link
Contributor

sseerrggii commented Mar 20, 2018 •
edited
Loading

Sorry, I deleted gemfile in my commit 😱 when a newbie plays on github...

sauloperez
sauloperez reviewed Mar 20, 2018
View reviewed changes
config/locales/pt-BR.yml
@@ -518,6 +518,7 @@ pt-BR:
accounts: Contas
balance: 'Balanço:'
categories: Serviços Oferecidos
change_your_image:
Copy link
Collaborator

@sauloperez sauloperez Mar 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a problem @sseerrggii ? I guess this will be displayed as an empty string which might be troublesome.

Copy link
Collaborator Author

@markets markets Mar 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so @sauloperez, we are using i18n.fallbacks = true so it should render the default_locale, in our case i18n.default_locale = :es. Example:

captura de pantalla 2018-03-20 a las 11 53 04

@sauloperez
Copy link
Collaborator

I guess you fixed it with the push force, right @markets ?

@markets
Copy link
Collaborator Author

markets commented Mar 20, 2018

Yep @sauloperez, I fixed it with a push force (and taking texts from @sseerrggii's commit).

@sauloperez
Copy link
Collaborator

sauloperez commented Mar 20, 2018 •
edited
Loading

muy profesional 😂

@enricostano
Copy link
Contributor

Deployed to https://staging.timeoverflow.org

cc/ @sseerrggii

@sseerrggii
Copy link
Contributor

👍 Works fine!

@enricostano enricostano merged commit aa353e5 into develop Apr 4, 2018
@enricostano enricostano deleted the gravatar_link branch April 4, 2018 11:27
@sseerrggii sseerrggii added this to the 1.4.1 milestone Apr 4, 2018
@sauloperez sauloperez mentioned this pull request Apr 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sauloperez sauloperez sauloperez approved these changes

@enricostano enricostano enricostano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markets @sauloperez @sseerrggii @enricostano