Require capistrano-rbenv only in staging #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Production is not provisioned with Rbenv yet. We're first refactoring staging's provisioning and then, we'll work on production. So, this patch is temporary. This fixes the issue we had in https://github.com/coopdevs/timeoverflow/releases/tag/v1.3.0 while deploying and https://github.com/coopdevs/timeoverflow/releases/tag/v1.3.1 fixed.
|
Maybe we can create an issue or a trello card to remind us to remove this ASAP and make it a dependency of https://trello.com/c/UCMTlV3g |
enricostano
approved these changes
Feb 9, 2018
|
We definitely need to keep track of this |
sauloperez
added a commit
that referenced
this pull request
Feb 9, 2018
* develop: Require capistrano-rbenv only in staging Add unicorn configuration This brings the patch that skips capistrano-rbenv when deploying to production. See: #325 As a result, we also bring in the new staging's unicorn config file, but this has no effect in production as no config file is specified in /etc/systemd/system/timeoverflow.service.
Merged
|
Documented in a Trello card |
enricostano
reviewed
Mar 19, 2018
| require 'capistrano/rbenv' | ||
|
|
||
| stage = ARGV.first | ||
| if stage == :staging # Sorry, production is not ready yet |
There was a problem hiding this comment.
'staging' not `:staging'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production is not provisioned with Rbenv yet. We're first refactoring staging's provisioning and then, we'll work on production. So, this patch is temporary.
This fixes the issue we had in https://github.com/coopdevs/timeoverflow/releases/tag/v1.3.0 while
deploying and https://github.com/coopdevs/timeoverflow/releases/tag/v1.3.1 fixed.
Then we can bring these changes related to
capistrano-rbenvback tomaster.