Move give time action to transfers controller

.rubocop.yml

@@ -188,7 +188,7 @@ SpecialGlobalVars:
   Enabled: false
 
 StringLiterals:
-  EnforcedStyle: double_quotes
+  EnforcedStyle: single_quotes
 
 VariableInterpolation:
   Enabled: false

app/controllers/organizations_controller.rb

@@ -48,14 +48,6 @@ def destroy
     redirect_to organizations_path, notice: "deleted"
   end
 
-  def give_time
-    @destination = @organization.account.id
-    @source = find_transfer_source
-    @offer = find_transfer_offer
-    @transfer = Transfer.new(source: @source, destination: @destination)
-    @sources = find_transfer_sources_for_admin
-  end
-
   def set_current
     if current_user
       session[:current_organization_id] = @organization.id
@@ -70,20 +62,4 @@ def organization_params
                                      public_opening_times description address
                                      neighborhood city domain])
   end
-
-  def find_transfer_offer
-    current_organization.offers.
-      find(params[:offer]) if params[:offer].present?
-  end
-
-  def find_transfer_source
-    current_user.members.
-      find_by(organization: @organization).account.id
-  end
-
-  def find_transfer_sources_for_admin
-    return unless admin?
-    [current_organization.account] +
-      current_organization.member_accounts.where("members.active is true")
-  end
 end

app/controllers/transfers_controller.rb

@@ -6,12 +6,29 @@ def create
       transfer_params.merge(source: @source, destination: @account)
     )
 
-    begin
-      transfer.save!
-    rescue ActiveRecord::RecordInvalid
-      flash[:error] = transfer.errors.full_messages.to_sentence
-    end
+    transfer.save!
     redirect_to redirect_target
+  rescue ActiveRecord::RecordInvalid
+    flash[:error] = transfer.errors.full_messages.to_sentence
+  end
+
+  def new
+    transfer_factory = TransferFactory.new(
+      current_organization,
+      current_user,
+      params[:offer],
+      params[:destination_account_id]
+    )
+
+    render(
+      :new,
+      locals: {
+        accountable: transfer_factory.accountable,
+        transfer: transfer_factory.build_transfer,
+        offer: transfer_factory.offer,
+        sources: transfer_factory.transfer_sources
+      }
+    )
   end
 
   def delete_reason

app/controllers/users_controller.rb

@@ -61,18 +61,6 @@ def update
     end
   end
 
-  def give_time
-    @user = scoped_users.find(params[:id])
-    @destination = @user.members.
-                   find_by(organization: current_organization).account.id
-    @source = find_transfer_source
-    @offer = find_transfer_offer
-    @transfer = Transfer.new(source: @source,
-                             destination: @destination,
-                             post: @offer)
-    @sources = find_transfer_sources_for_admin
-  end
-
   private
 
   def user_params
@@ -85,22 +73,6 @@ def user_params
     params.require(:user).permit *fields_to_permit
   end
 
-  def find_transfer_offer
-    current_organization.offers.
-      find(params[:offer]) if params[:offer].present?
-  end
-
-  def find_transfer_source
-    current_user.members.
-      find_by(organization: current_organization).account.id
-  end
-
-  def find_transfer_sources_for_admin
-    return unless admin?
-    [current_organization.account] +
-      current_organization.member_accounts.where("members.active is true")
-  end
-
   def find_user
     if current_user.id == params[:id].to_i
       current_user

app/helpers/transfers_helper.rb

@@ -1,2 +1,9 @@
 module TransfersHelper
+  def accountable_path(accountable)
+    if accountable.is_a?(Organization)
+      organization_path(accountable)
+    else
+      user_path(accountable.user)
+    end
+  end
 end

app/models/member.rb

@@ -29,6 +29,15 @@ def display_name_with_uid
     "#{user} (#{member_uid})"
   end
 
+  # Returns the id to be displayed in the :new transfer page
+  #
+  # @params _destination_accountable used to keep the same API as
+  #   Organization#display_id
+  # @return [Integer]
+  def display_id(_destination_accountable)
+    member_uid
+  end
+
   def remove_all_posts_from_index
     Post.with_member.where("members.id = ?", self.id).find_each do |post|
       post.delete_document

app/models/organization.rb

@@ -28,6 +28,23 @@ def to_s
     "#{name}"
   end
 
+  def display_name_with_uid
+    self
+  end
+
+  # Returns the id to be displayed in the :new transfer page with the given
+  # destination_accountable
+  #
+  # @params destination_accountable [Organization | Object] target of a transfer
+  # @return [Integer | String]
+  def display_id(destination_accountable)
+    if destination_accountable.is_a?(Organization)
+      account.accountable_id
+    else
+      ''
+    end
+  end
+
   def ensure_reg_number_seq!
     update_column(:reg_number_seq, members.maximum(:member_uid))
   end

app/models/transfer_factory.rb

@@ -0,0 +1,80 @@
+class TransferFactory
+  def initialize(current_organization, current_user, offer_id, destination_account_id)
+    @current_organization = current_organization
+    @current_user = current_user
+    @offer_id = offer_id
+    @destination_account_id = destination_account_id
+  end
+
+  # Returns the offer that is the subject of the transfer
+  #
+  # @return [Maybe<Offer>]
+  def offer
+    current_organization.offers.find_by_id(offer_id)
+  end
+
+  # Returns a new instance of Transfer with the data provided
+  #
+  # @return [Transfer]
+  def build_transfer
+    transfer = Transfer.new(source: source, destination: destination_account.id)
+    transfer.post = offer unless for_organization?
+    transfer
+  end
+
+  def transfer_sources
+    if admin?
+      [current_organization.account] +
+        current_organization.member_accounts.merge(Member.active)
+    else
+      []
+    end
+  end
+
+  def accountable
+    @accountable ||= destination_account.accountable
+  end
+
+  private
+
+  attr_reader :current_organization, :current_user, :offer_id,
+              :destination_account_id
+
+  # Returns the id of the account that acts as source of the transfer.
+  # Either the account of the organization or the account of the current user.
+  #
+  # @return [Maybe<Integer>]
+  def source
+    organization = if accountable.is_a?(Organization)
+                     accountable
+                   else
+                     current_organization
+                   end
+
+    current_user.members.find_by(organization: organization).account.id
+  end
+
+  # Checks whether the destination account is an organization
+  #
+  # @return [Boolean]
+  def for_organization?
+    destination_account.accountable.class == Organization
+  end
+
+  def admin?
+    current_user.try :manages?, current_organization
+  end
+
+  # TODO: this method implements authorization by scoping the destination
+  # account in all the accounts of the current organization. If the specified
+  # destination account does not belong to it, the request will simply faily.
+  #
+  # Returns the account the time will be transfered to
+  #
+  # @return [Account]
+  def destination_account
+    @destination_account ||= current_organization
+      .all_accounts
+      .find(destination_account_id)
+  end
+end

app/models/transfer_sources_options.rb

@@ -0,0 +1,43 @@
+# Wraps the passed sources as a collection of HTML <option>'s value and text
+# pairs as expected by Rails' #options_for_select.
+class TransferSourcesOptions
+  # Constructor
+  #
+  # @param sources [Array<Account>]
+  # @param destination_accountable [Member | Organization]
+  def initialize(sources, destination_accountable)
+    @sources = sources
+    @destination_accountable = destination_accountable
+  end
+
+  # Returns the collection as an Array containing pairs of <option>'s text and
+  # value sorted by accountable type and member_uid
+  #
+  # @return [Array<String, Integer>]
+  def to_a
+    sources
+      .sort_by { |account| to_accountable_type_and_uid(account) }
+      .map { |account| to_text_and_value(account) }
+  end
+
+  private
+
+  attr_reader :sources, :destination_accountable
+
+  def to_accountable_type_and_uid(account)
+    [account.accountable_type, account.accountable.try(:member_uid)]
+  end
+
+  def to_text_and_value(account)
+    accountable = account.accountable
+
+    [
+      "#{display_id(accountable)} #{accountable.class} #{accountable}",
+      account.id
+    ]
+  end
+
+  def display_id(accountable)
+    accountable.display_id(destination_accountable)
+  end
+end

app/views/offers/show.html.erb

@@ -12,7 +12,7 @@
     <% end %>
   <% end %>
   <% if current_user and @offer.user != current_user %>
-    <%= link_to give_time_user_path(@offer.user, offer: @offer.id),
+    <%= link_to new_transfer_path(id: @offer.user.id, offer: @offer.id),
                 class: "btn btn-success" do %>
       <%= glyph :time %>
       <%= t ".give_time_for" %>

app/views/organizations/show.html.erb

@@ -110,7 +110,7 @@
         </li>
       <% end %>
       <li>
-        <%= link_to give_time_organization_path(@organization) do %>
+        <%= link_to new_transfer_path(id: @organization, destination_account_id: @organization.account.id) do %>
           <%= glyph :time %>
           <%= t "global.give_time" %>
         <% end %>

app/views/transfers/_member_offer.html.erb

@@ -0,0 +1,6 @@
+<% if offer %>
+  <%= form.input :post, readonly: true %>
+  <%= form.input :post_id, as: :hidden %>
+<% else %>
+  <%= form.input :post_id, collection: accountable.offers.active %>
+<% end %>

app/views/transfers/_organization_offer.html.erb

@@ -0,0 +1,3 @@
+<% if offer %>
+  <%= form.input :post, as: :hidden %>
+<% end %>

app/views/transfers/_sources.html.erb

@@ -0,0 +1,9 @@
+<div class="form-group">
+  <%= form.label :source %>
+  <%= form.select :source,
+    options_for_select(
+      TransferSourcesOptions.new(sources, accountable).to_a,
+      selected: current_user.member(current_organization).account.id
+    ), {}, id: "select2-time", class: "form-control"
+  %>
+</div>