Do not fetch destination when the user is guest

Author: sauloperez

app/controllers/offers_controller.rb

@@ -21,10 +21,13 @@ def dashboard
 
   def show
     super
-    @destination_account = @offer
-      .user
-      .members
-      .find_by(organization: current_organization)
-      .account
+
+    if current_user
+      @destination_account = @offer
+        .user
+        .members
+        .find_by(organization: current_organization)
+        .account
+    end
   end
 end

spec/controllers/offers_controller_spec.rb

@@ -62,24 +62,22 @@
   describe "GET #show" do
     context "with valid params" do
       context "with a logged user" do
-        it "assigns the requested offer to @offer" do
-          login(another_member.user)
+        before { login(another_member.user) }
 
-          get "show", id: offer.id
+        it "assigns the requested offer to @offer" do
+          get :show, id: offer.id
           expect(assigns(:offer)).to eq(offer)
         end
 
         it 'assigns the account destination of the transfer' do
-          login(another_member.user)
-
           get :show, id: offer.id
           expect(assigns(:destination_account)).to eq(member.account)
         end
       end
 
       context "without a logged in user" do
         it "assigns the requested offer to @offer" do
-          get "show", id: offer.id
+          get :show, id: offer.id
           expect(assigns(:offer)).to eq(offer)
         end
       end