Skip to content

Add FilePlayer support for urls with query string #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2016
Merged

Add FilePlayer support for urls with query string #45

merged 1 commit into from
Apr 8, 2016

Conversation

gridsane
Copy link
Contributor

@gridsane gridsane commented Apr 4, 2016

File urls could have a query string. For example: vk.com API returns the following urls:

https://psv4.vk.me/c611426/u238196536/audios/ccd84e1ca642.mp3?extra=HASH

@cookpete
Copy link
Owner

cookpete commented Apr 5, 2016

Nice job. The dist files don't need to be committed though. They are only for the sake of bower, and are built and added to the repo as part of the version bump script. Remove them from the commit and we are good to go!

@gridsane
Copy link
Contributor Author

gridsane commented Apr 6, 2016

Done.
Thanks for the awesome component!

@cookpete
Copy link
Owner

cookpete commented Apr 6, 2016

Could you squash your new commit into the previous one?

@gridsane
Copy link
Contributor Author

gridsane commented Apr 6, 2016

Okay, done.

PS. Not sure if squash is visible in notifications.

@cookpete cookpete merged commit f0d2ffb into cookpete:master Apr 8, 2016
@cookpete
Copy link
Owner

cookpete commented Apr 8, 2016

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gridsane @cookpete