Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeError: Maximum call stack size exceeded with a slightly complex query #414

Open
capaj opened this issue Jun 1, 2019 · 0 comments
Open

Comments

@capaj
Copy link

capaj commented Jun 1, 2019

here: https://github.com/apollographql/apollo-client/blob/451482ff85d93e1738df31007f3c2a7f0fbe8cff/packages/apollo-client/src/core/ObservableQuery.ts#L262

there is a call which tries to compare two objects.
The problem I get when I switch to hermes from apollo-cache-inmemory is that these objects are circular. Proof:
image

IMHO the fix should either be to make the objects not be circular or the isEqual: https://github.com/apollographql/apollo-client/blob/451482ff85d93e1738df31007f3c2a7f0fbe8cff/packages/apollo-utilities/src/util/isEqual.ts#L4
needs to be able to handle circular objects.

I have

    "apollo-client": "^2.6.0",
    "apollo-cache-hermes": "^0.8.9",
@capaj capaj changed the title RangeError: Maximum call stack size exceeded RangeError: Maximum call stack size exceeded with a slightly complex query Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant