Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: convox/rack
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 20230614151114
Choose a base ref
...
head repository: convox/rack
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 20230619214423
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Jun 19, 2023

  1. [#3685] Fix Spot instances preventing rack from updating 

    ### What is the feature/fix?

Add missing commands from launch config to launch template and use spot lifecycle.

### Does it has a breaking change?

No, fix rack update when spot instance bid is set.

### How to use/test it?

- Install a rack on [20230427130715](https://github.com/convox/rack/releases/tag/20230427130715).
- Create and deploy an app.
- Scale the app (e.g. `convox scale SERVICENAME --count=20`)
- Then try to install the RC (creating**)

### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
    @nightfury1204
    nightfury1204 committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    80cf032 View commit details
    Browse the repository at this point in the history

  2. [#3683] Reimplement whitelisting for rack api 

    ### What is the feature/fix?

https://app.asana.com/0/1203637156732418/1204758574004435/f

### Add screenshot or video (optional)

** Any screenshot or video capture using the feature **

### Does it has a breaking change?

no

### How to use/test it?

### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
    @nightfury1204
    nightfury1204 committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    573fbe4 View commit details
    Browse the repository at this point in the history

  3. Turn off the log check for whitelisting

    @nightfury1204
    nightfury1204 committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    fcb6894 View commit details
    Browse the repository at this point in the history
Loading