feat(config): check min version in GetLinter, GetFormatter

Author: muthukrishnan24

config/config.go

@@ -155,12 +155,20 @@ func WriteConfToFile(outFilePath string, conf *lint.Config) (retErr error) {
 	return enc.Encode(conf)
 }
 
-func checkVersion(verInfo string) error {
-	if verInfo == "" {
+func checkVersion(versionNo string) error {
+	if versionNo == "" {
 		return errors.New("version is empty")
 	}
-	if !semver.IsValid(verInfo) {
+	if !semver.IsValid(versionNo) {
 		return errors.New("invalid version should be in semver format")
 	}
-	return nil
+	return checkIfMinVersion(versionNo)
+}
+
+func checkIfMinVersion(versionNo string) error {
+	cmp := semver.Compare(Version(), versionNo)
+	if cmp != -1 {
+		return nil
+	}
+	return fmt.Errorf("min version required is %s. you have %s.\nupgrade commitlint", versionNo, Version())
 }

config/lint.go

@@ -3,15 +3,14 @@ package config
 import (
 	"fmt"
 
-	"golang.org/x/mod/semver"
-
 	"github.com/conventionalcommit/commitlint/lint"
 )
 
 // GetLinter returns Linter for given confFilePath
 func GetLinter(conf *lint.Config) (*lint.Linter, error) {
-	if !checkIfMinVersion(conf) {
-		return nil, fmt.Errorf("min version required is %s. you have %s. \nupgrade commitlint", conf.Version, Version())
+	err := checkIfMinVersion(conf.Version)
+	if err != nil {
+		return nil, err
 	}
 
 	rules, err := GetEnabledRules(conf)
@@ -23,6 +22,11 @@ func GetLinter(conf *lint.Config) (*lint.Linter, error) {
 
 // GetFormatter returns the formatter as defined in conf
 func GetFormatter(conf *lint.Config) (lint.Formatter, error) {
+	err := checkIfMinVersion(conf.Version)
+	if err != nil {
+		return nil, err
+	}
+
 	format, ok := globalRegistry.GetFormatter(conf.Formatter)
 	if !ok {
 		return nil, fmt.Errorf("config error: '%s' formatter not found", conf.Formatter)
@@ -55,7 +59,3 @@ func GetEnabledRules(conf *lint.Config) ([]lint.Rule, error) {
 
 	return enabledRules, nil
 }
-
-func checkIfMinVersion(conf *lint.Config) bool {
-	return semver.Compare(Version(), conf.Version) != -1
-}