feat: add support for bumping version # in bower.json #148
Conversation
|
@lexich I've released support for
|
|
@bcoe nice. I think that the next step should be to adding support pluggins for different file formats. |
| configsToUpdate[configPath] = true | ||
| } | ||
| } catch (err) { | ||
| if (err.code !== 'ENOENT') console.warn(err.message) |
There was a problem hiding this comment.
@bcoe This PR is so cool, thanks for getting back into the project so strongly, I've been AWOL due to increased pressure at our startup but am trying to catch up too.
I'm slightly concerned about the fact that any write errors will be ignored, e.g. if you have a bower.json you would presumably want to have it updated too. If the write fails, you'll just get a error but the git commits etc. will go through!
I haven't yet settled on an opinion on how this should be handled, but I think it's part of a bigger problem related to rolling back changes if an error occurs during the whole run..
There was a problem hiding this comment.
rolling back changes will be a awesome feature
working from @lexich's foundation, this pull adds support for bumping version # in multiple config files in a generic way.