feat(container): switch to Alpine container #4185
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
/cc @kaiehrhardt @knocte would you mind having a look at this? |
|
I have no idea about how this Dockerfile.ci is used |
This reduces the container image size from about 950MB to 200MB. Closes conventional-changelog#4183.
|
@escapedcat lgtm |
|
Is there a list of system dependencies for commitlint? I just realized yesterday that I forgot to add git, and I'm wondering whether there are more dependencies. Previously, many "basic" tools were available from the large base image, but they would now be missing if not explicitly installed. Are there other things I should test? |
Haven't seen one. I'm also not exactly sure. Maybe we try this, give it a try and adjust if needed? |
|
Jumping back on this PR. Is there anything still missing here, or shall we merge as @escapedcat suggested? |
|
@skycaptain hey, yes, sorry! Let me merge it these days and we'll see what happens ;) |
escapedcat
merged commit 93be696
into
conventional-changelog:master
|
Done 🤞 |
|
Looks like this went well? |
With the switch to Alpine in conventional-changelog#4185, `--from-last-tag` no longer works. This is because git is no longer available in the container.
With the switch to Alpine in conventional-changelog#4185, `--from-last-tag` no longer works. This is because git is no longer available in the container.
With the switch to Alpine in conventional-changelog#4185, `--from-last-tag` no longer works. This is because git is no longer available in the container.
With the switch to Alpine in conventional-changelog#4185, `--from-last-tag` no longer works. This is because git is no longer available in the container.
With the switch to Alpine in conventional-changelog#4185, `--from-last-tag` no longer works. This is because git is no longer available in the container.
With the switch to Alpine in #4185, `--from-last-tag` no longer works. This is because git is no longer available in the container.
Description
This reduces the container image size from about 950MB to 200MB.
Closes #4183.
Motivation and Context
See #4183
How Has This Been Tested?
$ docker buildx build -f Dockerfile.ci .Types of changes
Although I've labeled this as a non-breaking change, it could potentially disrupt containers derived from this image. Please consider reclassifying it as a breaking change if necessary.
Checklist: