Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: sharable -> shareable #4120

Merged
merged 1 commit into from
Aug 13, 2024
Merged

docs: sharable -> shareable #4120

merged 1 commit into from
Aug 13, 2024

Conversation

rdimaio
Copy link
Contributor

@rdimaio rdimaio commented Aug 13, 2024

Description

Prior to this commit, there were 41 occurrences of "shareable" and 2 of "sharable". As they all refer to the concept of shareable configs, I think it would be clearer to use the same form of "shareable" in all occurrences of the word.

Motivation and Context

Making docs more consistent

Usage examples

N/A

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Prior to this commit, there were 41 occurrences of "shareable" and 2 of "sharable".
As they all refer to the concept of shareable configs,
I think it would be clearer to use the same form of "shareable"
in all occurrences of the word.
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@escapedcat
Copy link
Member

Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants