Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(load): update cosmiconfig to v9 to add support for package.yaml config #3976

Conversation

danielbayley
Copy link
Contributor

Description

See relevant cosmiconfig release notes, and cosmiconfig/cosmiconfig#334 for context.

Motivation and Context

Enable support for reading commitlint configuration directly from package.yaml.

Usage examples

# package.yaml
commitlint:
  extends:
  - "@commitlint/config-conventional"
  rules:
    body-case: [2, always, sentence-case]

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codesandbox-ci bot commented Mar 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@danielbayley danielbayley force-pushed the cosmiconfig-package-yaml branch from 07e57fd to acc8e8d Compare March 14, 2024 19:36
@danielbayley danielbayley changed the title feat: update cosmiconfig to v9 to add support for package.yaml config feat(load): update cosmiconfig to v9 to add support for package.yaml config Mar 14, 2024
@escapedcat
Copy link
Member

escapedcat commented Mar 15, 2024

Thanks @danielbayley ! Can you fix the linting check? Then we can merge this

@danielbayley danielbayley force-pushed the cosmiconfig-package-yaml branch from acc8e8d to 46a1fab Compare March 15, 2024 02:38
@danielbayley
Copy link
Contributor Author

Thanks @danielbayley ! Can you fix the linting check? Then we can merge this

@escapedcat Done.

@escapedcat escapedcat merged commit 94eab40 into conventional-changelog:master Mar 15, 2024
7 checks passed
@escapedcat
Copy link
Member

https://github.com/conventional-changelog/commitlint/releases/tag/v19.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants