Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect esmodule project #3773

Closed
wants to merge 1 commit into from
Closed

fix: detect esmodule project #3773

wants to merge 1 commit into from

Conversation

pfdgithub
Copy link

Description

fix #3768
I'm not sure why you want to override the default js dynamic loader, so I just kept the default js dynamic loader in the esmodule project.

Motivation and Context

Usage examples

// commitlint.config.js
module.exports = {};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joberstein
Copy link
Contributor

I'd like to look into this a little more; node 20.8 fixed a memory leak that was happening with dynamic imports, and the JS sync loader should've been the default in the previous commitment/load version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment