-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow extending settings via config #150
feat: allow extending settings via config #150
Conversation
Thanks for contributing this PR. I'd prefer a format that combines the enum values with the descriptions, e.g.: rules: {
'scope-enum': () => {
const scopes = [
{value: 'auth', description: 'something something' },
{value: 'settings', description: 'something differnt'}
];
return [2, 'always', scopes];
}
} Cool things about this:
What do you think? |
Hi, unfortunately I’m not yet that familiar to the codebase to be able to come up with a new format or something that’s scope specific. I took a look at the settings at prompt and replicated that format. |
Yeah sure, I'd implement that change myself. I'd like your perspective as an API consumer on that one, though. |
@marionebl I think the API you proposed looks solid for me as a consumer. I was actually just looking for this feature now so I hope this gets implemented soon. :) |
I think the problem with that is that while it solves the scope problem, we'll need something custom just like this for, let's say, IMHO think having both would the best but I'd definitely give this one a second look. |
Closing this for now. The extension of the configuration by "described values" is on the roadmap. |
Any progress on this? Couldn't find any mention outside of the README. |
Hey @mogelbrod , didn't see your comment, sorry. There wasn't any progress afaik. |
Simplified usage (there's a lot more dynamic stuff on my config, so apologies for typos/syntax):