Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] Add support for the new breaking change "bang" #632

Closed
1 of 4 tasks
byCedric opened this issue Apr 26, 2019 · 1 comment
Closed
1 of 4 tasks

[Spec] Add support for the new breaking change "bang" #632

byCedric opened this issue Apr 26, 2019 · 1 comment

Comments

@byCedric
Copy link
Member

Expected Behavior

In the latest version of the conventional commits (1.0.0-beta.4) a new feature is added to define "breaking changes". It's still in beta but already released as specification-feature. This means we could add some new rules to validate this. We also have to update our type rules to make them play nice with this I guess.

conventional-commits/conventionalcommits.org#134

Possible implementations

We can modify the type-enum rule to only allow trailing ! in this rule, or we can modify @commitlint/ensure to let it pass too. I prefer the first one because e.g. scopes should not have this functionality right?

Current Behavior

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

@byCedric
Copy link
Member Author

Closed in favor of #658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant