Skip to content

bug: treats body with URL as footer #4101

Open
@abitrolly

Description

@abitrolly

Steps to Reproduce

1. Add this commit message:

fix: ingest - do not double strip /doc/ prefix

It is already stripped here
https://gitlab.com/gitlab-community/modelops/applied-ml/code-suggestions/ai-assist/-/blob/22bb9cf2b996dc2ec347bad761abb12fd11bcf75/scripts/ingest/gitlab-docs/steps/parse.rb#L16
  1. Watch commitlint failure for footer

Current Behavior

⧗   input: fix: ingest - do not double strip /doc/ prefix
It is already stripped here
https://gitlab.com/gitlab-community/modelops/applied-ml/code-suggestions/ai-assist/-/blob/22bb9cf2b996dc2ec347bad761abb12fd11bcf75/scripts/ingest/gitlab-docs/steps/parse.rb#L16
✖   footer's lines must not be longer than 100 characters [footer-max-line-length]
⚠   footer must have leading blank line [footer-leading-blank]
✖   found 1 problems, 1 warnings

Expected Behavior

⧗   --- input ---
fix: ingest - do not double strip /doc/ prefix

It is already stripped here
https://gitlab.com/gitlab-community/modelops/applied-ml/code-suggestions/ai-assist/-/blob/22bb9cf2b996dc2ec347bad761abb12fd11bcf75/scripts/ingest/gitlab-docs/steps/parse.rb#L16
✖   body's lines must not be longer than 100 characters [body-max-line-length]
✖   found 1 warnings

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

Add the example to tests that cover bugs to be fixed.

Fix parser to return these lines in body.

Context

https://gitlab.com/gitlab-community/modelops/applied-ml/code-suggestions/ai-assist/-/jobs/7372910347

commitlint --version

i don't know

git --version

i don't know

node --version

i don't know

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions