Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: body-max-line-length is not respecting footer-max-line-length and failing for long footers #4088

Open
1 of 4 tasks
rsampaths16 opened this issue Jun 12, 2024 · 1 comment

Comments

@rsampaths16
Copy link

rsampaths16 commented Jun 12, 2024

Steps to Reproduce

1. First step
set rules 

{
  "body-max-line-length": [2, "always", 100],
  "footer-max-line-length": [2, "always", 150],
}

2. Second step
In commit have a footer greater than 100 characters and less than 150 characters

Current Behavior

The commitlint fails with body-max-line-length

Expected Behavior

It shouldn't fail with body-max-line-length as footer-max-line-length is respected

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

No response

Context

Am facing this issue when using the commitlint-pre-commit-hook plugin for pre-commit.

Have current suppressed the checks with the following config

module.exports = {
    extends: ['@commitlint/config-conventional'],
    rules: {
        'body-max-line-length': [0, 'always', 0],
        'footer-max-line-length': [0, 'always', 0],
    }
};

commitlint --version

@commitlint/cli@19.3.0

git --version

v2.39.3

node --version

v12.22.12

@rsampaths16 rsampaths16 changed the title fix: **body-max-line-length** is not respecting **footer-max-line-length** and failing for long footers fix: body-max-line-length is not respecting footer-max-line-length and failing for long footers Jun 12, 2024
@SalahAdDin
Copy link

I'm having the same issue right now, you can check here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants