Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: config-angular header-max-length should be 100 #303

Closed
1 of 4 tasks
FabienDehopre opened this issue Mar 1, 2018 · 6 comments
Closed
1 of 4 tasks

Feature: config-angular header-max-length should be 100 #303

FabienDehopre opened this issue Mar 1, 2018 · 6 comments
Labels

Comments

@FabienDehopre
Copy link

FabienDehopre commented Mar 1, 2018

Expected Behavior

In the angular config package, the rule header-max-length should be set to 100 characters.

Any line of the commit message cannot be longer 100 characters!
cfr Angular Contributing Doc

Current Behavior

For the moment, the header line is configurered to only allow 72 characters.

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

Configure the rule header-max-length to 100 characters.

Your Environment

Executable Version
commitlint --version 6.1.0
git --version git version 2.15.1.windows.2
node --version v8.9.1
@FabienDehopre FabienDehopre changed the title Feature: config-angular line max length should be 100 Feature: config-angular header-max-length should be 100 Mar 1, 2018
@FabienDehopre
Copy link
Author

BTW, new rules should be created to restrict body and footer line length. For the moment, there are 2 rules to restrict both the body and footer length but not the line length used to create the body and footer.

These rules could be body-max-line-length and footer-max-line-length. What do you think about this?

@marionebl
Copy link
Contributor

Thanks for the suggestions. To my knowledge the change from 72 to 100 char length in headers happened during the Angular.js to Angular transition, also see https://github.com/marionebl/commitlint/issues/146.

config-angular still tracks Angular.js, while there is no config that tracks Angular - they change their conventions to often to be useful outside of their project nowadays.

Concerning body-max-line-length, footer-max-line-length: Sure a PR implementing them would be welcome! Related issue: https://github.com/marionebl/commitlint/issues/208

@Fetz
Copy link
Contributor

Fetz commented Aug 20, 2018

@marionebl since both body-max-line-length, footer-max-line-length was added to the rules should they be added to the config-angular? If yes what should be their value?

if 100 to be aligned to Angular, then we should change the header as well to 100
if not we should use 72 to be the same as the header

@marionebl
Copy link
Contributor

@Fetz Let's go with 100 in config-conventional

@mightyiam
Copy link
Contributor

I requested for 100 in in config-conventional, as well. #859 .

@escapedcat
Copy link
Member

We released v9.0.1 under the next tag. This should include the updated max-length rule.
Give it a try and provide feedback. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

5 participants