Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace '@endemolshinegroup/cosmiconfig-typescript-loader' #2912

Closed
4 tasks
xboy2012 opened this issue Dec 9, 2021 · 11 comments · Fixed by #2914
Closed
4 tasks

replace '@endemolshinegroup/cosmiconfig-typescript-loader' #2912

xboy2012 opened this issue Dec 9, 2021 · 11 comments · Fixed by #2914

Comments

@xboy2012
Copy link

xboy2012 commented Dec 9, 2021

Expected Behavior

Please replace @endemolshinegroup/cosmiconfig-typescript-loader with cosmiconfig-typescript-loader

Beacuse:

  1. @endemolshinegroup/cosmiconfig-typescript-loader is a private package,
  2. @endemolshinegroup/cosmiconfig-typescript-loader is not active maintained and all PRs are block for almost 1 year.

Current Behavior

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

Steps to Reproduce (for bugs)

  1. First step
  2. Second step
commitlint.config.js ```js ```

Context

EndemolShineGroup/cosmiconfig-typescript-loader#200

Your Environment

Executable Version
commitlint --version VERSION
git --version VERSION
node --version VERSION
@escapedcat
Copy link
Member

Thanks for the heads up.
Any idea how this could be replaced? No worries if not.

@xboy2012
Copy link
Author

xboy2012 commented Dec 10, 2021

Thanks for the heads up. Any idea how this could be replaced? No worries if not.

Just replace the package with the new one, not too much work.

The API keeps the same, as far as I can see. But it's still better to have a full test.

Sorry I don't have a PR now.
(Because the network problem in my company, Pull/Push github codes via client is forbidden. )

@escapedcat
Copy link
Member

Just replace the package with the new one, not too much work.

Ah, sorry, should have read your description more carefully, thanks, will do!

Sorry I don't have a PR now. (Because the network problem in my company, Pull/Push github codes via client is forbidden. )

😵‍💫 😮‍💨

@escapedcat
Copy link
Member

Done, would you mind having a look @xboy2012 ?
#2914

@xboy2012
Copy link
Author

I commented the PR #2914

Except one diff, everything looks OK

@escapedcat
Copy link
Member

Where did you comment? I don't see anything

@xboy2012
Copy link
Author

image
I updated the comment just now

@escapedcat
Copy link
Member

Hey, yeah thanks for checking! This is intended:
https://github.com/Codex-/cosmiconfig-typescript-loader#usage

  loaders: {
    ".ts": TypeScriptLoader(),
  },

@escapedcat
Copy link
Member

Will be fixed with the next release

@xboy2012
Copy link
Author

Will be fixed with the next release

When will the next release come out? Seems a week passed by.

@escapedcat
Copy link
Member

Yeah, bit busy, will try to do it soon-ish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants