-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure a smooth transition from Angular.js to Angular conventions #146
Comments
https://greenkeeper.io/ creates chore commits as well. |
Also, I've got following report on the automatic commit made by Greenkeeper:
I don't understand the first one. Why is the commit message |
@honzajavorek Thanks for reporting, I'll have a closer look at the first one - looks like a bug.
|
I tried to update the config to the newest conventions as described in the Angular project and released this prematurely. (they forbid "chore" now) I reset the |
From version 5, `chore` type is deleted. See https://github.com/marionebl/commitlint/issues/146
From version 5, `chore` type is deleted. See https://github.com/marionebl/commitlint/issues/146
since i forgot the link in the last commit, for reference: https://github.com/marionebl/commitlint/issues/146
Update 2017-11-30
As discussed with the conventional-changelog team in conventional-changelog/standard-version#220, the way forward for this will be a soft fork from the Angular convention, where we aim for
For this reason I created the
config-conventional
package with suggestions what the fork should look like. Work related toconventional-changelog
is tracked in conventional-changelog/standard-version#220.The conventions underpinning
config-angular
changed with the transition from Angular.js to Angular.commitlint reflects this in
config-angular@5
.This has not been reflected in the wider ecosystem so far, leading to incompatibilites.
To reinstantiate compat I set the
latest
tag back toconfig-angular@4
and taggedconfig-angular@5
asnext
.Open issues
standard-version produceschore
commits: WIP: fix: update to latest Angular commit conventions standard-version#220conventional-changelog suggestschore
commits: WIP: fix: update to latest angular commit conventions conventional-changelog#249no commit type applicable to things like releasing in Angular conventions: Incomplete type list in commit guidelines: add "release" type angular/angular#20537semantic-release creates chore commits@commitlint/config-angular
: v5 config-angular forces the type to uppercase #145Related
The text was updated successfully, but these errors were encountered: