Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure a smooth transition from Angular.js to Angular conventions #146

Open
5 tasks done
marionebl opened this issue Nov 20, 2017 · 4 comments
Open
5 tasks done

Ensure a smooth transition from Angular.js to Angular conventions #146

marionebl opened this issue Nov 20, 2017 · 4 comments

Comments

@marionebl
Copy link
Contributor

marionebl commented Nov 20, 2017

Update 2017-11-30

As discussed with the conventional-changelog team in conventional-changelog/standard-version#220, the way forward for this will be a soft fork from the Angular convention, where we aim for

  • config-conventional: used by conventional-changelog, commitlint, tracks conventionalcommits.org
  • config-angular: used by angular, tracks their commit conventions

For this reason I created the config-conventional package with suggestions what the fork should look like. Work related to conventional-changelog is tracked in conventional-changelog/standard-version#220.


The conventions underpinning config-angular changed with the transition from Angular.js to Angular.

  • chore is no longer allowed as commit type

commitlint reflects this in config-angular@5.

This has not been reflected in the wider ecosystem so far, leading to incompatibilites.
To reinstantiate compat I set the latest tag back to config-angular@4 and tagged config-angular@5 as next.

❯ npm show @commitlint/config-angular .dist-tags
{ latest: '4.3.0', next: '5.0.1' }

❯ npm show commitlint-config-angular .dist-tags
{ latest: '4.3.0', next: '5.0.1' }

Open issues

Related

@honzajavorek
Copy link
Contributor

honzajavorek commented Nov 20, 2017

https://greenkeeper.io/ creates chore commits as well.

@honzajavorek
Copy link
Contributor

Also, I've got following report on the automatic commit made by Greenkeeper:

⧗   input: chore(package): update @commitlint/config-angular to version 5.0.1
✖   subject must not be sentence-case,start-case,pascal-case,upper-case [subject-case]
✖   type must be one of [build, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]
✖   found 2 problems, 0 warnings

I don't understand the first one. Why is the commit message chore(package): update @commitlint/config-angular to version 5.0.1 invalid? I believe this was not an issue previously.

@marionebl
Copy link
Contributor Author

@honzajavorek Thanks for reporting, I'll have a closer look at the first one - looks like a bug.

✖   subject must not be sentence-case,start-case,pascal-case,upper-case [subject-case]

@marionebl
Copy link
Contributor Author

marionebl commented Nov 20, 2017

I don't understand the first one. Why is the commit message chore(package): update @commitlint/config-angular to version 5.0.1 invalid? I believe this was not an issue previously.

I tried to update the config to the newest conventions as described in the Angular project and released this prematurely. (they forbid "chore" now)

I reset the latest tag to config-angular@4, so we should have some time now to sort this out.

ybiquitous referenced this issue in interfirm/configs Nov 27, 2017
ybiquitous referenced this issue in interfirm/configs Nov 27, 2017
travi referenced this issue in travi/commitlint-config-travi Dec 16, 2017
bpedersen pushed a commit to bpedersen/commitlint that referenced this issue Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants