Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain minimal sensible config better #107

Closed
FezVrasta opened this issue Nov 2, 2017 · 7 comments
Closed

docs: explain minimal sensible config better #107

FezVrasta opened this issue Nov 2, 2017 · 7 comments

Comments

@FezVrasta
Copy link

image

I can't understand why commitlint doesn't throw error here?

@marionebl
Copy link
Contributor

Could you paste the content of your commitlint.config.js file?

@FezVrasta
Copy link
Author

no content, I guess it may be the problem? 🤔

@marionebl
Copy link
Contributor

Ah okay. commitlint basically does not do anything without configuration:

npm install --save-dev commitlint-config-angular
// commitlint.config.js
module.exports = {
  extends: ['angular']
};

@FezVrasta
Copy link
Author

I see, thanks!

@marionebl marionebl reopened this Nov 2, 2017
@marionebl
Copy link
Contributor

I'd like to keep this open as our docs are not clear enough as it seems.

@marionebl marionebl changed the title found 0 problems docs: explain minimal sensible config better Nov 2, 2017
@marionebl
Copy link
Contributor

Related to #48

@marionebl
Copy link
Contributor

We probably should warn when there is no config applied at all.

escapedcat added a commit to escapedcat/commitlint that referenced this issue Sep 26, 2018
escapedcat added a commit to escapedcat/commitlint that referenced this issue Nov 8, 2018
marionebl pushed a commit to escapedcat/commitlint that referenced this issue Nov 30, 2018
marionebl pushed a commit to escapedcat/commitlint that referenced this issue Nov 30, 2018
marionebl pushed a commit to escapedcat/commitlint that referenced this issue Nov 30, 2018
marionebl pushed a commit to escapedcat/commitlint that referenced this issue Nov 30, 2018
marionebl pushed a commit that referenced this issue Nov 30, 2018
* feat(load): display warning when config is empty #107

* fix(cli): show error if no rules defined #107

* test: remove failing marker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants