Skip to content

Fix codebase indexer config logic #5848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Conversation

RomneyDa
Copy link
Collaborator

If config hasn't loaded, don't kickoff indexing
Might be a race condition somewhere that needs to be addressed since this might cause indexing to not be kicked off sometimes.
But at least it fixes a bug and respects the setting

@RomneyDa RomneyDa requested a review from a team as a code owner May 26, 2025 18:56
@RomneyDa RomneyDa requested review from Patrick-Erichsen and removed request for a team May 26, 2025 18:56
Copy link

cubic-dev-ai bot commented May 26, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

Copy link

netlify bot commented May 26, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 98d065a
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/6834b9602fddc300081ef7ff

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 26, 2025
@RomneyDa RomneyDa requested a review from sestinj May 26, 2025 18:57
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 27, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs May 27, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit e4829bf into main May 27, 2025
36 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the dallin/indexing-logic-fix branch May 27, 2025 21:56
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs May 27, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants