Skip to content

win reg #5737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2025
Merged

win reg #5737

merged 3 commits into from
May 20, 2025
+77 −14

Conversation

sestinj
Copy link
Contributor

@sestinj sestinj commented May 19, 2025 •
edited
Loading

Description

This implements the MDM reader for Windows, using Windows Registry. It assumes we are on Windows, so the reg command should be available.

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Tests

I am testing this manually on Windows

Summary by cubic

Refactored the code to move array-to-object conversion logic into a helper function, fixing a linting error caused by nested code.

@sestinj sestinj mentioned this pull request May 19, 2025
Merged
3 tasks
@sestinj Graphite App
Copy link
Contributor Author

sestinj commented May 19, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sestinj sestinj mentioned this pull request May 19, 2025
Merged
3 tasks
@sestinj sestinj changed the title refactor to solve nesting linting error win reg May 20, 2025
@sestinj sestinj marked this pull request as ready for review May 20, 2025 00:54
@sestinj sestinj requested a review from a team as a code owner May 20, 2025 00:54
@sestinj sestinj requested review from Patrick-Erichsen and removed request for a team May 20, 2025 00:54
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 20, 2025
Patrick-Erichsen
Patrick-Erichsen previously approved these changes May 20, 2025
View reviewed changes
Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious if you looked around for any libraries that might do this for us, eg https://www.npmjs.com/package/@capacitor-community/mdm-appconfig ?

Otherwise this looks good to me 👍

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 20, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs May 20, 2025
Base automatically changed from mdm to main May 20, 2025 01:52
@sestinj sestinj dismissed Patrick-Erichsen’s stale review May 20, 2025 01:52

The base branch was changed.

@netlify Netlify
Copy link

netlify bot commented May 20, 2025 •
edited
Loading

✅ Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit d071de3
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/682be08e918f420008b8b7ef

@sestinj sestinj merged commit cacb71c into main May 20, 2025
36 checks passed
@sestinj sestinj deleted the windows-registry branch May 20, 2025 02:11
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs May 20, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Patrick-Erichsen Patrick-Erichsen Patrick-Erichsen left review comments

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Issues and PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sestinj @Patrick-Erichsen