fix[JB]: misc apply bugs #5708
Merged
fix[JB]: misc apply bugs #5708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrick-Erichsen
requested review from
tomasz-stefaniak
and removed request for
a team
dosubot
bot
added
the
size:XL
✅ Deploy Preview for continuedev canceled.
|
sestinj
approved these changes
May 17, 2025
| * Represents a range of text in a file with its contents. | ||
| * Provides utility methods for working with document positions and offsets. | ||
| */ | ||
| class RangeInFileWithContents( |
There was a problem hiding this comment.
This is a great pattern, we should do this more often (classes for data types that need attached utility methods)
There was a problem hiding this comment.
We should definitely write unit tests for it, but nothing changed and this PR is such a large improvement that I want to merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by mrge
Fixed several bugs with applying diffs in the JetBrains plugin, improved diff streaming and rejection logic, and updated the UI to reflect changes more accurately.
Bug Fixes
Refactors