Skip to content

Fix apply state actions generating state #5640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025
Merged

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented May 13, 2025

Fixes the following cases:

  • showing "pending" when not tool call related
  • showing generating while pending
  • showing generating when not the last codeblock
  • size/alignment of apply generating stuff looked weird on multiple lines, fixed with min-content width

Summary by mrge

Fixed issues with code generation status display so "pending" and "generating" states now show correctly for the last code block and tool calls.

  • Bug Fixes
    • Removed "pending" status for non-tool call actions.
    • Only show "generating" for the last code block while streaming.
    • Fixed status display when not on the last code block.

@RomneyDa RomneyDa requested a review from a team as a code owner May 13, 2025 02:14
@RomneyDa RomneyDa requested review from Patrick-Erichsen and removed request for a team May 13, 2025 02:14
Copy link

netlify bot commented May 13, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 037e358
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/68238fb3b20d9c0008eb5744

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 13, 2025
@RomneyDa RomneyDa changed the title Fix apply state actions: generating Fix apply state actions generating state May 13, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 13, 2025
@RomneyDa RomneyDa merged commit e30aa42 into main May 13, 2025
61 of 64 checks passed
@RomneyDa RomneyDa deleted the dallin/apply-actions branch May 13, 2025 19:15
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants