Skip to content

Commit fce1db2

Browse files
Chhavi-Mandowaradhruvparekh12
authored andcommitted
refactor:refactor method to simplify conditional logic
1 parent 8434092 commit fce1db2

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed

src/adapters/base-class.ts

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -747,22 +747,21 @@ export default class BaseClass {
747747

748748
async getEnvironment(): Promise<any> {
749749
const environmentFlagInput = this.config['environment'];
750-
if (environmentFlagInput) {
751-
const environmentList = await this.fetchEnvironments();
752-
const isValidEnvironment = environmentList.find((env: any) => env.name === environmentFlagInput || env.uid === environmentFlagInput);
753-
if (isValidEnvironment) {
754-
this.config.environment = isValidEnvironment.uid;
755-
return isValidEnvironment.uid;
756-
} else {
757-
this.log('Invalid environment name!', 'error');
758-
this.exit(1);
759-
}
760-
}
761-
else {
750+
751+
if (!environmentFlagInput) {
762752
const defaultEnvironment = (first(this.config.currentConfig.environments) as Record<string, any>)?.uid;
763753
this.config.environment = defaultEnvironment;
764754
return defaultEnvironment;
765755
}
756+
const environmentList = await this.fetchEnvironments();
757+
const isValidEnvironment = environmentList.find((env: any) => env.name === environmentFlagInput || env.uid === environmentFlagInput);
758+
759+
if (!isValidEnvironment) {
760+
this.log('Invalid environment name!', 'error');
761+
this.exit(1);
762+
}
763+
this.config.environment = isValidEnvironment.uid;
764+
return isValidEnvironment.uid;
766765
}
767766

768767
async fetchEnvironments(): Promise<any> {

0 commit comments

Comments
 (0)