Skip to content

Fix/dx 3187 sync locale data #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025

Conversation

harshithad0703
Copy link
Contributor

No description provided.

@harshithad0703 harshithad0703 requested a review from a team as a code owner June 30, 2025 09:17
@harshithad0703 harshithad0703 requested review from Copilot and removed request for a team June 30, 2025 09:17
Copilot

This comment was marked as outdated.

@harshithad0703 harshithad0703 requested a review from Copilot June 30, 2025 09:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where locale was being overwritten during data merges by deep-cloning before merging and re-applying the locale, and bumps the package version.

  • Preserve publish_details.locale when merging item data
  • Use cloneDeep to avoid mutating original objects
  • Increment version to 2.0.11

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/util/index.ts Clone items before merging and assign saved locale after merge
package.json Bump version from 2.0.10 to 2.0.11
Comments suppressed due to low confidence (2)

src/util/index.ts:154

  • Add or update unit tests to verify that locale from publish_details is correctly preserved after merging.
        items[i].locale = assetLocale

package.json:4

  • [nitpick] Consider updating the changelog or release notes to describe the locale preservation fix introduced in this version bump.
  "version": "2.0.11",

@harshithad0703 harshithad0703 marked this pull request as draft June 30, 2025 09:39
@harshithad0703 harshithad0703 marked this pull request as ready for review July 2, 2025 06:05
@harshithad0703 harshithad0703 merged commit af6a221 into development Jul 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants