-
Notifications
You must be signed in to change notification settings - Fork 2
Fix/dx 3133 urlencode for query string #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Back merge
Back merge
fix: method chaining for entry queryable class methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces URL encoding for query parameters in the SDK. Key changes include:
- Adding an encodeQueryParams utility function for recursive encoding of string values.
- Adding tests for the new encoding functionality in both unit and API test files.
- Extending the BaseQuery.find method with a new optional parameter to enable query parameter encoding.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
test/unit/utils.spec.ts | Added unit tests to verify proper encoding of special and nested characters. |
test/api/query-encoding.spec.ts | Added API tests to confirm encoding behavior under various query scenarios. |
src/lib/utils.ts | Introduced the encodeQueryParams function for encoding query parameters. |
src/lib/base-query.ts | Extended the find method to support an optional encoding flag. |
package.json | Bumped version to 4.7.1 as part of the changes. |
CHANGELOG.md | Updated changelog to reflect the changes introduced in 4.7.1. |
Comments suppressed due to low confidence (1)
src/lib/base-query.ts:205
- Consider adding inline documentation for the 'encode' parameter in the find method to clearly explain its purpose and usage.
async find<T>(encode: boolean = false): Promise<FindResponse<T>> {
We regret to inform you that you are currently not able to merge your changes into the main branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the development branch. Our team will then review the changes and work with you to ensure a successful merge into the main branch. |
We regret to inform you that you are currently not able to merge your changes into the main branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the development branch. Our team will then review the changes and work with you to ensure a successful merge into the main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.