Skip to content

Commit 14cb52a

Browse files
rohitmishra209rohitmishra209
authored
Merge pull request #3 from builtio-contentstack/add_param_method
Add param method
2 parents 1ef5dff + ac1296f commit 14cb52a

File tree

9 files changed

+73
-92
lines changed

9 files changed

+73
-92
lines changed

‎dist/native-script/contentstack.js‎

Lines changed: 21 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -785,12 +785,13 @@ var Stack = function () {
785785
}, {
786786
key: 'Assets',
787787
value: function Assets(uid) {
788-
var asset = new _assets2.default();
789788
this.type = 'asset';
790789
if (uid && typeof uid === "string") {
790+
var asset = new _assets2.default();
791791
asset.asset_uid = uid;
792+
return Utils.merge(asset, this);
792793
}
793-
return Utils.merge(asset, this);
794+
return this;
794795
}
795796

796797
/**
@@ -1472,7 +1473,6 @@ var Query = function (_Entry) {
14721473

14731474
_this._query = _this._query || {};
14741475
_this._query['query'] = _this._query['query'] || {};
1475-
14761476
/**
14771477
* @method lessThan
14781478
* @description This method provides only the entries with values less than the specified value for a field.
@@ -2448,30 +2448,27 @@ var Assets = function () {
24482448
* @example Assets().Query()
24492449
* @returns {Query}
24502450
*/
2451+
// Query() {
2452+
// let query = new Query();
2453+
// return Utils.merge(query, this);
2454+
// }
24512455

2456+
/**
2457+
* @method toJSON
2458+
* @description This method is used to convert the result in to plain javascript object.
2459+
* @example
2460+
* assetQuery
2461+
* .toJSON()
2462+
* .then(function (result) {
2463+
* let value = result.get(field_uid)
2464+
* },function (error) {
2465+
* // error function
2466+
* })
2467+
* @returns {Object}
2468+
*/
24522469

2453-
_createClass(Assets, [{
2454-
key: 'Query',
2455-
value: function Query() {
2456-
var query = new _query2.default();
2457-
return Utils.merge(query, this);
2458-
}
24592470

2460-
/**
2461-
* @method toJSON
2462-
* @description This method is used to convert the result in to plain javascript object.
2463-
* @example
2464-
* assetQuery
2465-
* .toJSON()
2466-
* .then(function (result) {
2467-
* let value = result.get(field_uid)
2468-
* },function (error) {
2469-
* // error function
2470-
* })
2471-
* @returns {Object}
2472-
*/
2473-
2474-
}, {
2471+
_createClass(Assets, [{
24752472
key: 'toJSON',
24762473
value: function toJSON() {
24772474
this.tojson = true;

‎dist/node/contentstack.js‎

Lines changed: 21 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -796,12 +796,13 @@ var Stack = function () {
796796
}, {
797797
key: 'Assets',
798798
value: function Assets(uid) {
799-
var asset = new _assets2.default();
800799
this.type = 'asset';
801800
if (uid && typeof uid === "string") {
801+
var asset = new _assets2.default();
802802
asset.asset_uid = uid;
803+
return Utils.merge(asset, this);
803804
}
804-
return Utils.merge(asset, this);
805+
return this;
805806
}
806807

807808
/**
@@ -1938,7 +1939,6 @@ var Query = function (_Entry) {
19381939

19391940
_this._query = _this._query || {};
19401941
_this._query['query'] = _this._query['query'] || {};
1941-
19421942
/**
19431943
* @method lessThan
19441944
* @description This method provides only the entries with values less than the specified value for a field.
@@ -7121,30 +7121,27 @@ var Assets = function () {
71217121
* @example Assets().Query()
71227122
* @returns {Query}
71237123
*/
7124+
// Query() {
7125+
// let query = new Query();
7126+
// return Utils.merge(query, this);
7127+
// }
71247128

7129+
/**
7130+
* @method toJSON
7131+
* @description This method is used to convert the result in to plain javascript object.
7132+
* @example
7133+
* assetQuery
7134+
* .toJSON()
7135+
* .then(function (result) {
7136+
* let value = result.get(field_uid)
7137+
* },function (error) {
7138+
* // error function
7139+
* })
7140+
* @returns {Object}
7141+
*/
71257142

7126-
_createClass(Assets, [{
7127-
key: 'Query',
7128-
value: function Query() {
7129-
var query = new _query2.default();
7130-
return Utils.merge(query, this);
7131-
}
71327143

7133-
/**
7134-
* @method toJSON
7135-
* @description This method is used to convert the result in to plain javascript object.
7136-
* @example
7137-
* assetQuery
7138-
* .toJSON()
7139-
* .then(function (result) {
7140-
* let value = result.get(field_uid)
7141-
* },function (error) {
7142-
* // error function
7143-
* })
7144-
* @returns {Object}
7145-
*/
7146-
7147-
}, {
7144+
_createClass(Assets, [{
71487145
key: 'toJSON',
71497146
value: function toJSON() {
71507147
this.tojson = true;

‎dist/react-native/contentstack.js‎

Lines changed: 21 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -785,12 +785,13 @@ var Stack = function () {
785785
}, {
786786
key: 'Assets',
787787
value: function Assets(uid) {
788-
var asset = new _assets2.default();
789788
this.type = 'asset';
790789
if (uid && typeof uid === "string") {
790+
var asset = new _assets2.default();
791791
asset.asset_uid = uid;
792+
return Utils.merge(asset, this);
792793
}
793-
return Utils.merge(asset, this);
794+
return this;
794795
}
795796

796797
/**
@@ -1472,7 +1473,6 @@ var Query = function (_Entry) {
14721473

14731474
_this._query = _this._query || {};
14741475
_this._query['query'] = _this._query['query'] || {};
1475-
14761476
/**
14771477
* @method lessThan
14781478
* @description This method provides only the entries with values less than the specified value for a field.
@@ -2448,30 +2448,27 @@ var Assets = function () {
24482448
* @example Assets().Query()
24492449
* @returns {Query}
24502450
*/
2451+
// Query() {
2452+
// let query = new Query();
2453+
// return Utils.merge(query, this);
2454+
// }
24512455

2456+
/**
2457+
* @method toJSON
2458+
* @description This method is used to convert the result in to plain javascript object.
2459+
* @example
2460+
* assetQuery
2461+
* .toJSON()
2462+
* .then(function (result) {
2463+
* let value = result.get(field_uid)
2464+
* },function (error) {
2465+
* // error function
2466+
* })
2467+
* @returns {Object}
2468+
*/
24522469

2453-
_createClass(Assets, [{
2454-
key: 'Query',
2455-
value: function Query() {
2456-
var query = new _query2.default();
2457-
return Utils.merge(query, this);
2458-
}
24592470

2460-
/**
2461-
* @method toJSON
2462-
* @description This method is used to convert the result in to plain javascript object.
2463-
* @example
2464-
* assetQuery
2465-
* .toJSON()
2466-
* .then(function (result) {
2467-
* let value = result.get(field_uid)
2468-
* },function (error) {
2469-
* // error function
2470-
* })
2471-
* @returns {Object}
2472-
*/
2473-
2474-
}, {
2471+
_createClass(Assets, [{
24752472
key: 'toJSON',
24762473
value: function toJSON() {
24772474
this.tojson = true;

‎dist/web/contentstack.js‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎examples/node/contentstack-demo.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class ContentstackDemo {
2323
*/
2424
getEntries(contentTypeUid) {
2525
contentTypeUid = contentTypeUid || 'source'
26-
return this.Stack.ContentType(contentTypeUid).Query().toJSON().find()
26+
return this.Stack.ContentType(contentTypeUid).Query().where('title', "hometestfinal").toJSON().find()
2727
}
2828

2929
/**
@@ -55,7 +55,7 @@ class ContentstackDemo {
5555
*/
5656
getAsset(assetUid) {
5757
assetUid = assetUid || 'blt123something'
58-
return this.Stack.Assets(assetUid).fetch()
58+
return this.Stack.Assets(assetUid).addParam('include_dimension', 'true').fetch()
5959
}
6060

6161
}

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "contentstack",
3-
"version": "3.3.0",
3+
"version": "3.4.0",
44
"description": "Contentstack Javascript SDK",
55
"homepage": "https://www.contentstack.com/",
66
"author": {

‎src/core/modules/assets.js‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,6 @@ export default class Assets {
3434
return this;
3535
}
3636

37-
/**
38-
* @method Query
39-
* @description Query instance to provide support for all search queries.
40-
* @example Assets().Query()
41-
* @returns {Query}
42-
*/
43-
Query() {
44-
let query = new Query();
45-
return Utils.merge(query, this);
46-
}
47-
4837
/**
4938
* @method toJSON
5039
* @description This method is used to convert the result in to plain javascript object.

‎src/core/modules/query.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,11 @@ const _extend = {
9090
* @ignore
9191
*/
9292
export default class Query extends Entry {
93+
9394
constructor() {
9495
super();
9596
this._query = this._query || {};
9697
this._query['query'] = this._query['query'] || {};
97-
9898
/**
9999
* @method lessThan
100100
* @description This method provides only the entries with values less than the specified value for a field.

‎src/core/stack.js‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -209,16 +209,17 @@ export default class Stack {
209209
* @method Assets
210210
* @description Set the Asset Uid which you want to retrive the Asset.
211211
* @param {String} uid - asset_uid
212-
* @example Stack.Assets('blt1234567890abcef')
212+
* @example Stack.Assets('blt1234567890abcef').fetch
213213
* @returns {Assets}
214214
*/
215215
Assets(uid) {
216-
let asset = new Assets();
217216
this.type = 'asset';
218217
if (uid && typeof uid === "string") {
218+
let asset = new Assets();
219219
asset.asset_uid = uid;
220+
return Utils.merge(asset, this);
220221
}
221-
return Utils.merge(asset, this);
222+
return this;
222223
}
223224

224225
/**

0 commit comments

Comments
 (0)