Skip to content

Remove catching of exception on Entry fetch #78

@Scorze

Description

@Scorze

Hi everyone,
I saw that as part of issue #67 the try catch mechanism for the method fetchFromNetwork has been removed from the Query class to allow handling and retries of different types of exceptions. Can we have the same done for Entry as well?

This is the piece of code I'm referring to

    private void fetchFromNetwork(String urlString, JSONObject urlQueries, EntryResultCallBack callBack) {
        try {
            JSONObject mainJson = new JSONObject();
            setIncludeJSON(urlQueries, callBack);
            mainJson.put("query", urlQueries);
            HashMap<String, Object> urlParams = getUrlParams(mainJson);
            new CSBackgroundTask(this, contentType.stackInstance, Constants.FETCHENTRY, urlString, this.headers,
                    urlParams, Constants.REQUEST_CONTROLLER.ENTRY.toString(), callBack);
        } catch (Exception e) {
            throwException(null, e, callBack);
        }
    }

So from this, the try-catch would be removed.

Thank you!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions