Skip to content

Commit 67e116e

Browse files
authored
Merge pull request #1699 from contentstack/fix/DX-1781
Fix/dx 1781
2 parents c6be15f + 3e7467c commit 67e116e

File tree

8 files changed

+33
-18
lines changed

8 files changed

+33
-18
lines changed

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/contentstack-export/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"bugs": "https://github.com/contentstack/cli/issues",
77
"dependencies": {
88
"@contentstack/cli-command": "~1.3.2",
9-
"@contentstack/cli-variants": "~1.1.3",
9+
"@contentstack/cli-variants": "~1.1.4",
1010
"@contentstack/cli-utilities": "~1.8.0",
1111
"@oclif/core": "^3.27.0",
1212
"async": "^3.2.6",

packages/contentstack-import/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"@contentstack/cli-command": "~1.3.2",
1010
"@contentstack/cli-utilities": "~1.8.0",
1111
"@contentstack/management": "~1.18.4",
12-
"@contentstack/cli-variants": "~1.1.3",
12+
"@contentstack/cli-variants": "~1.1.4",
1313
"@oclif/core": "^3.27.0",
1414
"big-json": "^3.2.0",
1515
"bluebird": "^3.7.2",

packages/contentstack-variants/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@contentstack/cli-variants",
3-
"version": "1.1.3",
3+
"version": "1.1.4",
44
"description": "Variants plugin",
55
"main": "lib/index.js",
66
"types": "lib/index.d.ts",

packages/contentstack-variants/src/import/experiences.ts

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export default class Experiences extends PersonalizationAdapter<ImportConfig> {
4545
const conf: APIConfig = {
4646
config,
4747
baseURL: config.modules.personalize.baseURL[config.region.name],
48-
headers: { 'X-Project-Uid': config.modules.personalize.project_id},
48+
headers: { 'X-Project-Uid': config.modules.personalize.project_id },
4949
cmaConfig: {
5050
baseURL: config.region.cma + `/v3`,
5151
headers: { api_key: config.apiKey },
@@ -141,8 +141,11 @@ export default class Experiences extends PersonalizationAdapter<ImportConfig> {
141141
const jobRes = await this.validateVariantGroupAndVariantsCreated();
142142
fsUtil.writeFile(this.cmsVariantPath, this.cmsVariants);
143143
fsUtil.writeFile(this.cmsVariantGroupPath, this.cmsVariantGroups);
144-
if (jobRes)
144+
if (jobRes) {
145145
this.log(this.config, this.$t(this.messages.CREATE_SUCCESS, { module: 'Variant & Variant groups' }), 'info');
146+
} else {
147+
this.personalizeConfig.importData = false;
148+
}
146149

147150
if (this.personalizeConfig.importData) {
148151
this.log(this.config, this.messages.UPDATING_CT_IN_EXP, 'info');
@@ -162,7 +165,11 @@ export default class Experiences extends PersonalizationAdapter<ImportConfig> {
162165
* function import experience versions from a JSON file and creates them in the project.
163166
*/
164167
async importExperienceVersions(experience: ExperienceStruct, oldExperienceUid: string) {
165-
const versionsPath = resolve(sanitizePath(this.experiencesDirPath), 'versions', `${sanitizePath(oldExperienceUid)}.json`);
168+
const versionsPath = resolve(
169+
sanitizePath(this.experiencesDirPath),
170+
'versions',
171+
`${sanitizePath(oldExperienceUid)}.json`,
172+
);
166173

167174
if (!existsSync(versionsPath)) {
168175
return;
@@ -231,7 +238,7 @@ export default class Experiences extends PersonalizationAdapter<ImportConfig> {
231238
try {
232239
const promises = this.pendingVariantAndVariantGrpForExperience.map(async (expUid) => {
233240
const expRes = await this.getExperience(expUid);
234-
if (expRes?._cms) {
241+
if (expRes?._cms && expRes?._cms?.variantGroup && Object.keys(expRes._cms.variants).length > 0) {
235242
this.cmsVariants[expUid] = expRes._cms?.variants ?? {};
236243
this.cmsVariantGroups[expUid] = expRes._cms?.variantGroup ?? {};
237244
return expUid; // Return the expUid for filtering later

packages/contentstack-variants/src/import/project.ts

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,13 @@ export default class Project extends PersonalizationAdapter<ImportConfig> {
2828
async import() {
2929
const personalize = this.config.modules.personalize;
3030
const { dirName, fileName } = personalize.projects;
31-
const projectPath = join(sanitizePath(this.config.data), sanitizePath(personalize.dirName), sanitizePath(dirName), sanitizePath(fileName));
32-
31+
const projectPath = join(
32+
sanitizePath(this.config.data),
33+
sanitizePath(personalize.dirName),
34+
sanitizePath(dirName),
35+
sanitizePath(fileName),
36+
);
37+
3338
if (existsSync(projectPath)) {
3439
const projects = JSON.parse(readFileSync(projectPath, 'utf8')) as CreateProjectInput[];
3540

@@ -46,7 +51,10 @@ export default class Project extends PersonalizationAdapter<ImportConfig> {
4651
description: project.description,
4752
connectedStackApiKey: this.config.apiKey,
4853
}).catch(async (error) => {
49-
if (error.includes('personalization.PROJECTS.DUPLICATE_NAME') || error.includes('personalize.PROJECTS.DUPLICATE_NAME')) {
54+
if (
55+
error.includes('personalization.PROJECTS.DUPLICATE_NAME') ||
56+
error.includes('personalize.PROJECTS.DUPLICATE_NAME')
57+
) {
5058
const projectName = await askProjectName('Copy Of ' + (newName || project.name));
5159
return await createProject(projectName);
5260
}

packages/contentstack/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"@contentstack/cli-migration": "~1.6.4",
4040
"@contentstack/cli-utilities": "~1.8.0",
4141
"@contentstack/management": "~1.18.4",
42-
"@contentstack/cli-variants": "~1.1.3",
42+
"@contentstack/cli-variants": "~1.1.4",
4343
"@contentstack/cli-cm-import-setup": "1.0.0-beta.1",
4444
"@oclif/core": "^3.27.0",
4545
"@oclif/plugin-help": "^5",

pnpm-lock.yaml

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)