@@ -2,7 +2,7 @@ import traverse from 'traverse';
22import { klona } from 'klona/full' ;
33import { normalize } from 'path' ;
44import * as winston from 'winston' ;
5- import { levelColors , logLevels } from '../constants/logging' ;
5+ import { levelColors , logLevels , PROGRESS_SUPPORTED_MODULES } from '../constants/logging' ;
66import { LoggerConfig , LogLevel , LogType } from '../interfaces/index' ;
77import { configHandler } from '..' ;
88
@@ -58,8 +58,22 @@ export default class Logger {
5858 } ) ,
5959 ] ;
6060
61- // Add console transport only if showConsoleLogs is true
62- if ( configHandler && typeof configHandler . get === 'function' && configHandler . get ( 'showConsoleLogs' ) ) {
61+ // Determine console logging based on configuration
62+ let showConsoleLogs = true ;
63+
64+ if ( configHandler && typeof configHandler . get === 'function' ) {
65+ const logConfig = configHandler . get ( 'log' ) || { } ;
66+ const hasProgressSupport = PROGRESS_SUPPORTED_MODULES . includes ( logConfig . progressSupportedModule ) ;
67+ if ( hasProgressSupport ) {
68+ // Plugin has progress bars - respect user's showConsoleLogs setting
69+ showConsoleLogs = logConfig . showConsoleLogs ?? true ;
70+ } else {
71+ // Plugin doesn't have progress support - always show console logs
72+ showConsoleLogs = true ;
73+ }
74+ }
75+
76+ if ( showConsoleLogs ) {
6377 transports . push (
6478 new winston . transports . Console ( {
6579 format : winston . format . combine (
@@ -110,9 +124,8 @@ export default class Logger {
110124
111125 private shouldLog ( level : LogType , target : 'console' | 'file' ) : boolean {
112126 const configLevel = target === 'console' ? this . config . consoleLogLevel : this . config . logLevel ;
113- const minLevel = configLevel ? logLevels [ configLevel ] : logLevels [ 'info' ] ; // Default to info level
114- const currentLevel = logLevels [ level ] || logLevels [ 'info' ] ; // Handle undefined levels
115- return currentLevel <= minLevel ;
127+ const minLevel = configLevel ? logLevels [ configLevel ] : 2 ;
128+ return logLevels [ level ] <= minLevel ;
116129 }
117130
118131 /* === Public Log Methods === */
@@ -137,7 +150,7 @@ export default class Logger {
137150
138151 public success ( message : string , meta ?: any ) : void {
139152 if ( this . shouldLog ( 'success' , 'console' ) || this . shouldLog ( 'success' , 'file' ) ) {
140- this . loggers . success . info ( message , { ...meta , type : 'success' } ) ;
153+ this . loggers . success . log ( 'success' , message , { ...meta } ) ;
141154 }
142155 }
143156
@@ -245,7 +258,7 @@ export default class Logger {
245258 } ,
246259 } ;
247260 if ( this . shouldLog ( 'success' , 'console' ) || this . shouldLog ( 'success' , 'file' ) ) {
248- this . loggers . success . info ( logPayload ) ;
261+ this . loggers . success . log ( logPayload ) ;
249262 }
250263 }
251264
0 commit comments