fix: polling logic for app action call (#1806)

Author: vikaskumr

lib/adapters/REST/endpoints/app-action-call.ts

@@ -8,6 +8,7 @@ import {
 import * as raw from './raw'
 import { RestEndpoint } from '../types'
 import { GetAppActionCallDetailsParams, GetAppActionCallParams } from '../../../common-types'
+import { isSuccessful, shouldRePoll, waitFor } from '../../../common-utils'
 
 export const create: RestEndpoint<'AppActionCall', 'create'> = (
   http: AxiosInstance,
@@ -50,28 +51,46 @@ async function callAppActionResult(
     callId: string
   }
 ) {
-  const appActionResponse = await getCallDetails(http, { ...params, callId })
+  const result = await getCallDetails(http, { ...params, callId })
 
-  if (appActionResponse && appActionResponse.sys && appActionResponse.sys.id) {
-    resolve(appActionResponse)
+  // The lambda failed or returned a 404, so we shouldn't re-poll anymore
+  if (result?.response?.statusCode && !isSuccessful(result?.response?.statusCode)) {
+    const error = new Error(result.response.body)
+    reject(error)
+  }
+
+  if (isSuccessful(result.statusCode)) {
+    resolve(result)
+  }
+
+  // The logs are not ready yet. Continue waiting for them
+  if (shouldRePoll(result.statusCode) && checkCount !== retries) {
+    waitFor(retryInterval)
+
+    await callAppActionResult(http, params, {
+      resolve,
+      reject,
+      retryInterval,
+      retries,
+      checkCount,
+      callId,
+    })
   } else if (checkCount === retries) {
     const error = new Error()
     error.message = 'The app action response is taking longer than expected to process.'
     reject(error)
   } else {
     checkCount++
-    setTimeout(
-      () =>
-        callAppActionResult(http, params, {
-          resolve,
-          reject,
-          retryInterval,
-          retries,
-          checkCount,
-          callId,
-        }),
-      retryInterval
-    )
+    waitFor(retryInterval)
+
+    await callAppActionResult(http, params, {
+      resolve,
+      reject,
+      retryInterval,
+      retries,
+      checkCount,
+      callId,
+    })
   }
 }
 

lib/common-utils.ts

@@ -36,3 +36,14 @@ export const wrapCursorPaginatedCollection =
     // @ts-expect-error
     return collectionData
   }
+export function isSuccessful(statusCode: number) {
+  return statusCode < 300
+}
+
+export function shouldRePoll(statusCode: number) {
+  return [404, 422, 429].includes(statusCode)
+}
+
+export async function waitFor(ms = 1000) {
+  return new Promise((resolve) => setTimeout(resolve, ms))
+}