feat: bump app-script & add add-locations script [EXT-6267] #9586
Conversation
✅ Deploy Preview for ecommerce-app-base-components canceled.
|
| @@ -3,7 +3,7 @@ | |||
| "build": "contentful-app-scripts build-functions --ci" | |||
There was a problem hiding this comment.
Decided not to add script as I believe the intent with these is that they are merged with another template that has the script
| @@ -3,7 +3,7 @@ | |||
| "build": "contentful-app-scripts build-functions --ci" | |||
There was a problem hiding this comment.
Decided not to add script as I believe the intent with these is that they are merged with another template that has the script
| @@ -3,6 +3,6 @@ | |||
| "build": "contentful-app-scripts build-functions --ci" | |||
There was a problem hiding this comment.
Decided not to add script as I believe the intent with these is that they are merged with another template that has the script
| @@ -3,7 +3,7 @@ | |||
| "build": "contentful-app-scripts build-functions --ci" | |||
There was a problem hiding this comment.
Decided not to add script as I believe the intent with these is that they are merged with another template that has the script
| @@ -3,6 +3,6 @@ | |||
| "build": "contentful-app-scripts build-functions --ci" | |||
There was a problem hiding this comment.
Decided not to add script as I believe the intent with these is that they are merged with another template that has the script
| @@ -3,7 +3,7 @@ | |||
| "build": "contentful-app-scripts build-functions --ci" | |||
There was a problem hiding this comment.
Decided not to add script as I believe the intent with these is that they are merged with another template that has the script
| @@ -3,7 +3,7 @@ | |||
| "build": "contentful-app-scripts build-functions --ci" | |||
There was a problem hiding this comment.
Decided not to add script as I believe the intent with these is that they are merged with another template that has the script
| @@ -3,7 +3,7 @@ | |||
| "build": "contentful-app-scripts build-functions --ci" | |||
There was a problem hiding this comment.
Decided not to add script as I believe the intent with these is that they are merged with another template that has the script
| @@ -3,6 +3,6 @@ | |||
| "build": "contentful-app-scripts build-functions --ci" | |||
There was a problem hiding this comment.
Decided not to add script as I believe the intent with these is that they are merged with another template that has the script
| @@ -3,7 +3,7 @@ | |||
| "build": "contentful-app-scripts build-functions --ci" | |||
There was a problem hiding this comment.
Decided not to add script as I believe the intent with these is that they are merged with another template that has the script
BobHemphill76
force-pushed
the
feat/ext-6267/bump-app-scripts-examples
branch
from
4affc8d to
a8f20c8
Compare
|
Let me rebase with your PR and I'll take a peek at those README's and add where it makes sense |
BobHemphill76
force-pushed
the
feat/ext-6267/bump-app-scripts-examples
branch
from
a8f20c8 to
9bc4f3c
Compare
| @@ -22,8 +22,13 @@ You will need to set the following environment variables as listed below: | |||
|
|
|||
| It as simple using the CLI command `npm run upload-ci`. This will perform two actions: upload the code, linking it to the app, and then finally activating the code ready for usage in both | |||
|
|
|||
| ### Adding locations to an app | |||
|
|
|||
| You can add locations to an existing app using CLI using `npm run add-locations`. This will launch an interactive prompt, allowing you to select locations to add to your app. | |||
There was a problem hiding this comment.
I think this first sentence can be updated to: You can add locations to an existing app using the CLI command npm run add-locations (this would apply to all the MD changes)
There was a problem hiding this comment.
Got it. I updated the create-app-definition MD as well to reflect that sentence structure
BobHemphill76
force-pushed
the
feat/ext-6267/bump-app-scripts-examples
branch
from
b263ec5 to
7f27a5c
Compare
Purpose
Bump @contentful/app-scripts to ^2.3.0 for all examples
Add a new add-locations interactive script to all examples
Approach
Some of the examples have sub folders for javascript / typescript. For those the script was omitted under the assumption that those package scripts would be merged with another package that has the script.
Testing steps
From CCA I was able to create
npm run create-app-definitionfrom both foldersnpm run add-locationsfrom both foldersBreaking Changes
Dependencies and/or References
Deployment