-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Store the full URI in the search results #491
Conversation
Hard to say if 255 are enough. But imho that question is the same if it's a relative URL :D Most domains are not 250 characters long ;) |
I'd leave it as is for now. |
Merged in 3d03fe0. I have also patched contao.org to use absolute URLs and it seems to work like a charm. |
That's a bugfix then. Should be backported to 3.5. |
Yes. Will do if no problems occur. |
I can only test with Contao 3.5 right now, but if it's the same as doing 'url' => \Environment::get('uri') in /system/modules/core/classes/FrontendTemplate.php#L321, then yes, it works :) |
Yes, that is the same. In Contao 4, |
Back ported in contao/core@3e6dc79. |
Version 3.5.13 (2016-06-15) --------------------------- ### Fixed Use the correct empty value when resetting copied fields (see #8365). ### Fixed Remove the "required" attribute if a subpalette is closed (see #8192). ### Fixed Correctly generate the feed links in a multi-domain setup (see #8329). ### Fixed Correctly calculate the maximum file size for DropZone (see #8098). ### Fixed Do not adjust the start date of a multi-day event (see #8194). ### Fixed Versionize and show password changes (see #8301). ### Fixed Make File::$dirname an absolute path again (see #8325). ### Fixed Store the full URLs in the search index (see contao/core-bundle#491). ### Fixed Standardize the group names in the checkbox widget (see #8002). ### Fixed Prevent models from being registered twice (see #8224). ### Fixed Prevent horizontal scrolling in the ACE editor (see #8328). ### Fixed Correctly render the breadcrumb links in the template editor (see #8341). ### Fixed Remove the role attributes from the navigation templates (see #8343). ### Fixed Do not add `role="tablist"` to the accordion container (see #8344).
Description ----------- - Commits ------- a2ac550a Update StringUtil.php
This is the follow-up PR to contao/core#8331.
@fritzmg Does it solve your issue?
@Toflar Is
varchar(255)
long enough to store the full URI?