Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to show auth values in plaintext for debugging purposes #539

Closed
simskij opened this issue May 9, 2020 · 4 comments · Fixed by #541
Closed

Add a flag to show auth values in plaintext for debugging purposes #539

simskij opened this issue May 9, 2020 · 4 comments · Fixed by #541

Comments

@simskij
Copy link
Member

simskij commented May 9, 2020

This should be off by default, and clearly require some effort, like; --show-password-in-plaintext --i-accept-the-associated-risk both being present

@simskij
Copy link
Member Author

simskij commented May 9, 2020

Continuation of #537 and #517

@tammert
Copy link
Member

tammert commented May 9, 2020

I can pick this up as well, feel free to assign it so me.

Had a thought on this too: maybe instead of a very specific flag (disclaimer: I'm not a big fan of many niche flag options 😅), we could use the Trace log level already provided by Logrus?

I realize that this would actually still add an extra flag (--trace), but it seems realistic for Trace to print credentials, whereas it's probably a bit too much info for Debug. Might be handy in the future too for some niche logging statements.

@simskij let me know what you think, I don't mind implementing it either way!

@simskij
Copy link
Member Author

simskij commented May 9, 2020

Sounds good to me! 👌🏻

@ghost
Copy link

ghost commented May 11, 2020

To avoid important communication to get lost in a closed issues no one monitors, I'll go ahead and lock this issue. If you want to continue the discussion, please open a new issue. Thank you! 🙏🏼

@ghost ghost locked and limited conversation to collaborators May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants