Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional notification options #264

Closed
simskij opened this issue Apr 2, 2019 · 26 comments
Closed

Additional notification options #264

simskij opened this issue Apr 2, 2019 · 26 comments

Comments

@simskij
Copy link
Member

simskij commented Apr 2, 2019

Moving this discussion to a issue in shoutrrr.

Thanks for understanding! 🙏

@Codelica
Copy link

Codelica commented Apr 10, 2019

I like it, just wish Pushover were higher. 😇 I can help test that and Webhooks when the time comes.

Also for Webhooks please consider header support if possible, for Bearer authentication.

@simskij
Copy link
Member Author

simskij commented Apr 10, 2019

Lets move it up a bit then :)

@simskij
Copy link
Member Author

simskij commented Apr 20, 2019

These will be solved by replacing the current notification implementation with another project I'm working on; containrrr/shoutrrrr. Whether or not this will be in 0.4.0 or in a later release is not yet written in stone and depends a lot on whether im doing it by myself or with help. 😄

@simskij
Copy link
Member Author

simskij commented Apr 21, 2019

Discord, telegram, slack and pushover are all implemented in shoutrrr as of 5314ee954ba8dbc1c6eb6cbde310af695c8ae1da. Will implement a couple more before i'll even attempt integrating it.

@Codelica
Copy link

FWIW... I'm no Go expert, but I did made a little test run using a Pushover URL in Shoutrrr and it worked fine. :)

@somq
Copy link

somq commented Apr 24, 2019

Just to say, HTTP webhook is a killer feature imo.

@MAGICCC
Copy link

MAGICCC commented May 19, 2019

Neat, so we should wait until the shoutrrr code is in watchtower to use Telegram notifications?

@simskij
Copy link
Member Author

simskij commented May 19, 2019

Yeah. Feel free to help out though if you want it to happen sooner rather than later! :-)

@simskij simskij pinned this issue May 31, 2019
@simskij simskij changed the title Add additional notification options Additional notification options May 31, 2019
@alexanderadam
Copy link

alexanderadam commented Aug 2, 2019

Just to be sure: would it be possible to integrate more than one service with shoutrrr?
So i.e. to have notifications via email, XMPP and Sentry at the same time?

@simskij
Copy link
Member Author

simskij commented Aug 7, 2019

Just to be sure: would it be possible to integrate more than one service with shoutrrr?
So i.e. to have notifications via email, XMPP and Sentry at the same time?

yeah, that's our thought exactly! 👍 we've not really decided on how to do this in the case of watchtower, but yes - that will be possible in a general.

@noplanman
Copy link
Contributor

noplanman commented Aug 17, 2019

Just voicing my interest in the Telegram notifications. From the comments above it seems the wait is due to shoutrrr not being used in watchtower just yet.

What's the progress on that?

@simskij
Copy link
Member Author

simskij commented Jan 11, 2020

#405 should be taken into consideration when migrating to shoutrrr.

@deadmerc
Copy link

Hey guys, maybe like for temporary solution identifier will be append to message?
server-name-1: Starting Watchtower and scheduling first run:...

@davtur19
Copy link

davtur19 commented Mar 9, 2020

Are there updates for notifications on Telegram?

@simskij
Copy link
Member Author

simskij commented Mar 10, 2020

Unfortunately not. I've not had any time to work on switching the current notification module to shoutrrr.

@tcurdt
Copy link

tcurdt commented Mar 11, 2020

@simskij how much work to you suspect this will be? I haven't looked at the code at all, but are also craving for telegram and webhook support.

@davtur19
Copy link

Telegram's Bot API are very simple to use, but I don't know how to implement it since I don't know Go

For example to send a message (It also works with POST):
https://api.telegram.org/botTOKEN/sendMessage?chat_id=ID&text=TEXT

@mbrandau
Copy link
Contributor

mbrandau commented Mar 20, 2020

Telegram's Bot API are very simple to use, but I don't know how to implement it since I don't know Go

For example to send a message (It also works with POST):
https://api.telegram.org/botTOKEN/sendMessage?chat_id=ID&text=TEXT

@davtur19 Telegram seems to be implemented already. containrrr/shoutrrr#2

@davtur19
Copy link

@mbrandau yes, but has not yet been implemented/documented in
watchtower

@tcurdt
Copy link

tcurdt commented Mar 20, 2020

@davtur19 the problem is that watchtower needs to move to use shoutrrr and that's not been done yet.

@mbrandau
Copy link
Contributor

I will try to add shoutrrr as another notification type. WIP PR coming in soon. I have no experience in Go though 🙃

@mbrandau mbrandau mentioned this issue Mar 23, 2020
2 tasks
@simskij
Copy link
Member Author

simskij commented Mar 23, 2020

No better time to learn a new programming language than during quarantine! 😅

@mbrandau
Copy link
Contributor

One feature I’m missing while testing the new notifications on latest-dev is to disable the timestamps. Since I think most of the services show timestamps anyway, I think there should be an option to disable and/or format them in watchtower.

@arnested
Copy link
Member

Agree, @mbrandau.

The combination of timestamp, level and message doesn't really help on readability.

Maybe an environment variable with a template string to use?

@simskij
Copy link
Member Author

simskij commented Apr 27, 2020

Shoutrrr support will be included in the next release. It's already been merged to master, so I will go ahead and close this issue now. 🎉 Thank you so much everyone for your contributions!

@simskij simskij closed this as completed Apr 27, 2020
@ghost
Copy link

ghost commented Apr 27, 2020

To avoid important communication to get lost in a closed issues no one monitors, I'll go ahead and lock this issue. If you want to continue the discussion, please open a new issue. Thank you! 🙏🏼

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
@simskij simskij unpinned this issue Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests