Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable Verbosity for Slack Notifications #214

Closed
iMerica opened this issue Jul 26, 2018 · 6 comments
Closed

Customizable Verbosity for Slack Notifications #214

iMerica opened this issue Jul 26, 2018 · 6 comments

Comments

@iMerica
Copy link

iMerica commented Jul 26, 2018

It would be great to do a less noisy version of the Slack notifications.

Instead of this:

for container in containers:
   print [stopping|creating]  container ....

It would be great to to summarize this to:

All containers redeployed with latest image

@dbrgn
Copy link

dbrgn commented Sep 17, 2018

Alternatively, simply bundle the "found new image - stopping - creating - removing" messages into a single message. That would already reduce the "spam" quite significantly, especially when using Mattermost which does not seem to bundle the messages automatially:

screenshot

@simskij simskij changed the title Feature Request: Customizable Verbosity for Slack Notifications Customizable Verbosity for Slack Notifications Apr 7, 2019
@zoispag
Copy link
Member

zoispag commented Apr 9, 2019

Ideally allow us to provide a template file (using go template syntax, similar to Alert Manager for Prometheus), to be able to define our own format. That would be extremely useful!

{{ if gt (len .Notifications.Updated) 0 }}
  {{ range .Notifications.Updated }}
    Container {{ .Annotations.container }} was updated with ({{ .Annotations.imageName }}) {{ .Annotations.imageHash }}.
    {{ .Annotations.deletedHash }} has been deleted.
  {{ end }}
{{ end }}
{{ if gt (len .Notifications.Failed) 0 }}
  {{ range .Notifications.Failed }}
    There was a failure: {{ .Annotations.Error }}
  {{ end }}
{{ end }}

And I would totally try to implement it and start a new PR, but my golang knowledge is not sufficient.

@zoispag
Copy link
Member

zoispag commented Apr 16, 2019

Bump up!?
Not a low priority for some of us! 😄

Not bugging though :)

@simskij
Copy link
Member

simskij commented Apr 16, 2019

I feel you, but I only have so many hours to put into open source each month.

It’s up for grabs though so if anyone want to take a stab at it; feel absolutely free. For now, however, I believe my time is better used elsewhere on the project.

🙏🏻

@stale
Copy link

stale bot commented May 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@simskij
Copy link
Member

simskij commented May 31, 2019

Closing this issue in favor of #255 which is aimed towards a more generic (ie. not only for slack) solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants